Fix test cases

egregius313 · egregius313 · commit 6fdff977e500 · 2024-08-21T09:47:46.000-04:00
diff --git a/go/ql/test/library-tests/semmle/go/dataflow/flowsources/local/environment/test.go b/go/ql/test/library-tests/semmle/go/dataflow/flowsources/local/environment/test.go
@@ -86,6 +86,10 @@ func caarlos0EnvironmentVariables() {
 
 	cfg, err = env.ParseAs[config]() // $ source
 
+	if err != nil {
+		return
+	}
+
 	fmt.Printf("HOME: %s\n", cfg.Home)
 }
 
@@ -104,8 +108,8 @@ func syscallEnvironmentVariables() {
 		fmt.Println("%s", envVar)
 	}
 
-	home, err := syscall.Getenv("HOME") // $ source
-	if err != nil {
+	home, found := syscall.Getenv("HOME") // $ source
+	if !found {
 		return
 	}
 	fmt.Println("HOME: %s", home)

Original file line number	Diff line number	Diff line change
`@@ -86,6 +86,10 @@ func caarlos0EnvironmentVariables() {`
`86`	`86`
`87`	`87`	`cfg, err = env.ParseAs[config]() // $ source`
`88`	`88`
	`89`	`+ if err != nil {`
	`90`	`+ return`
	`91`	`+ }`
	`92`	`+`
`89`	`93`	`fmt.Printf("HOME: %s\n", cfg.Home)`
`90`	`94`	`}`
`91`	`95`
`@@ -104,8 +108,8 @@ func syscallEnvironmentVariables() {`
`104`	`108`	`fmt.Println("%s", envVar)`
`105`	`109`	`}`
`106`	`110`
`107`		`- home, err := syscall.Getenv("HOME") // $ source`
`108`		`- if err != nil {`
	`111`	`+ home, found := syscall.Getenv("HOME") // $ source`
	`112`	`+ if !found {`
`109`	`113`	`return`
`110`	`114`	`}`
`111`	`115`	`fmt.Println("HOME: %s", home)`