Skip to content

Commit 7128700

Browse files
committed
Simplified AngularInputUse class
1 parent 4891c1e commit 7128700

File tree

1 file changed

+4
-4
lines changed

1 file changed

+4
-4
lines changed

javascript/ql/lib/semmle/javascript/security/dataflow/RemoteFlowSources.qll

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -186,7 +186,7 @@ private class ExternalRemoteFlowSource extends RemoteFlowSource {
186186
}
187187

188188
/**
189-
* Angular @Input() decorator on a member declaration.
189+
* An Angular @Input() decorator on a member declaration.
190190
*/
191191
class InputMember extends MemberDeclaration {
192192
InputMember() {
@@ -199,7 +199,7 @@ class InputMember extends MemberDeclaration {
199199
}
200200

201201
/**
202-
* Use of an Angular @Input() member, modelled as `InputMember`.
202+
* A use of an Angular @Input() member, modeled as `InputMember`.
203203
*/
204204
class InputMemberUse extends DataFlow::Node {
205205
InputMemberUse() {
@@ -215,8 +215,8 @@ class InputMemberUse extends DataFlow::Node {
215215
/**
216216
* A remote flow source that is a member of an Angular component class.
217217
*/
218-
private class AngularInputUse extends RemoteFlowSource {
219-
AngularInputUse() { this instanceof InputMemberUse }
218+
private class AngularInputUse extends RemoteFlowSource, InputMemberUse {
219+
AngularInputUse() { this = this }
220220

221221
override string getSourceType() { result = "Angular @Input()" }
222222
}

0 commit comments

Comments
 (0)