Skip to content

Commit 714611f

Browse files
committed
Address review feedback
1 parent a63f18e commit 714611f

File tree

1 file changed

+4
-4
lines changed
  • java/ql/src/semmle/code/java/frameworks/apache

1 file changed

+4
-4
lines changed

java/ql/src/semmle/code/java/frameworks/apache/Lang.qll

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -122,14 +122,14 @@ private class ApacheStringUtilsTaintPreservingMethod extends TaintPreservingCall
122122
/**
123123
* A method declared on `org.apache.commons.lang3.text.StrBuilder`.
124124
*/
125-
abstract class ApacheStrBuilderMethod extends Callable {
125+
class ApacheStrBuilderMethod extends Method {
126126
ApacheStrBuilderMethod() {
127127
this.getDeclaringType().hasQualifiedName("org.apache.commons.lang3.text", "StrBuilder")
128128
}
129129
}
130130

131131
/**
132-
* An Apache Commons-Lang StrBuilder methods that add taint to the StrBuilder.
132+
* An Apache Commons Lang StrBuilder method that adds taint to the StrBuilder.
133133
*/
134134
private class ApacheStrBuilderTaintingMethod extends ApacheStrBuilderMethod, TaintPreservingCallable {
135135
ApacheStrBuilderTaintingMethod() {
@@ -170,7 +170,7 @@ private class ApacheStrBuilderTaintingMethod extends ApacheStrBuilderMethod, Tai
170170
}
171171

172172
/**
173-
* An Apache Commons-Lang StrBuilder methods that return taint from the StrBuilder.
173+
* An Apache Commons Lang StrBuilder method that returns taint from the StrBuilder.
174174
*/
175175
private class ApacheStrBuilderTaintGetter extends ApacheStrBuilderMethod, TaintPreservingCallable {
176176
ApacheStrBuilderTaintGetter() {
@@ -188,7 +188,7 @@ private class ApacheStrBuilderTaintGetter extends ApacheStrBuilderMethod, TaintP
188188
}
189189

190190
/**
191-
* An Apache Commons-Lang StrBuilder methods that write taint from the StrBuilder to some parameter.
191+
* An Apache Commons Lang StrBuilder method that writes taint from the StrBuilder to some parameter.
192192
*/
193193
private class ApacheStrBuilderTaintWriter extends ApacheStrBuilderMethod, TaintPreservingCallable {
194194
ApacheStrBuilderTaintWriter() { this.hasName(["appendTo", "getChars"]) }

0 commit comments

Comments
 (0)