C#: Gracefully handle non-zero exitcodes for dotnet --info.

Author: michaelnebel

csharp/extractor/Semmle.Extraction.CSharp.DependencyFetching/DotNet.cs

@@ -41,7 +41,7 @@ private void Info()
             var res = dotnetCliInvoker.RunCommand("--info", silent: false);
             if (!res)
             {
-                throw new Exception($"{dotnetCliInvoker.Exec} --info failed.");
+                logger.LogError($"{dotnetCliInvoker.Exec} --info was terminated unexpectedly.");
             }
         }
 

csharp/extractor/Semmle.Extraction.Tests/DotNet.cs

@@ -79,27 +79,6 @@ public void TestDotnetInfo()
             Assert.Equal("--info", lastArgs);
         }
 
-        [Fact]
-        public void TestDotnetInfoFailure()
-        {
-            // Setup
-            var dotnetCliInvoker = new DotNetCliInvokerStub(new List<string>()) { Success = false };
-
-            // Execute
-            try
-            {
-                _ = MakeDotnet(dotnetCliInvoker);
-            }
-
-            // Verify
-            catch (Exception e)
-            {
-                Assert.Equal("dotnet --info failed.", e.Message);
-                return;
-            }
-            Assert.Fail("Expected exception");
-        }
-
         [Fact]
         public void TestDotnetRestoreProjectToDirectory1()
         {