Merge pull request #6342 from MathiasVP/fix-fp-in-uninitialized-local

MathiasVP · web-flow · commit 73ee7409f663 · 2021-07-21T14:46:57.000+02:00
C++: Fix FP in `cpp/uninitialized-local`
diff --git a/cpp/ql/src/Likely Bugs/Memory Management/UninitializedLocal.ql b/cpp/ql/src/Likely Bugs/Memory Management/UninitializedLocal.ql
@@ -41,7 +41,7 @@ DeclStmt declWithNoInit(LocalVariable v) {
   result.getADeclaration() = v and
   not exists(v.getInitializer()) and
   /* The type of the variable is not stack-allocated. */
-  not allocatedType(v.getType())
+  exists(Type t | t = v.getType() | not allocatedType(t))
 }
 
 class UninitialisedLocalReachability extends StackVariableReachability {

Original file line number	Diff line number	Diff line change
`@@ -41,7 +41,7 @@ DeclStmt declWithNoInit(LocalVariable v) {`
`41`	`41`	`result.getADeclaration() = v and`
`42`	`42`	`not exists(v.getInitializer()) and`
`43`	`43`	`/* The type of the variable is not stack-allocated. */`
`44`		`- not allocatedType(v.getType())`
	`44`	`+ exists(Type t \| t = v.getType() \| not allocatedType(t))`
`45`	`45`	`}`
`46`	`46`
`47`	`47`	`class UninitialisedLocalReachability extends StackVariableReachability {`