Crypto: Bug fix in output model

bdrodes · bdrodes · commit 7477471bc5f2 · 2025-06-25T15:25:51.000-04:00
diff --git a/cpp/ql/lib/experimental/quantum/OpenSSL/Operations/CipherOperation.qll b/cpp/ql/lib/experimental/quantum/OpenSSL/Operations/CipherOperation.qll
@@ -181,7 +181,7 @@ class EvpCipherCall extends EvpCipherOperationFinalStep {
   }
 
   override DataFlow::Node getOutput(IOType type) {
-    super.getInput(type) = result
+    super.getOutput(type) = result
     or
     result.asExpr() = this.getArgument(1) and type = CiphertextIO()
   }
@@ -199,7 +199,7 @@ class EvpCipherFinalCall extends EvpCipherOperationFinalStep {
   }
 
   override DataFlow::Node getOutput(IOType type) {
-    super.getInput(type) = result
+    super.getOutput(type) = result
     or
     result.asDefiningArgument() = this.getArgument(1) and
     type = CiphertextIO()
@@ -224,7 +224,7 @@ class EvpPKeyCipherOperation extends EvpCipherOperationFinalStep {
   }
 
   override DataFlow::Node getOutput(IOType type) {
-    super.getInput(type) = result
+    super.getOutput(type) = result
     or
     result.asExpr() = this.getArgument(1) and type = CiphertextIO()
     // TODO: could indicate text lengths here, as well

Original file line number	Diff line number	Diff line change
`@@ -181,7 +181,7 @@ class EvpCipherCall extends EvpCipherOperationFinalStep {`
`181`	`181`	`}`
`182`	`182`
`183`	`183`	`override DataFlow::Node getOutput(IOType type) {`
`184`		`- super.getInput(type) = result`
	`184`	`+ super.getOutput(type) = result`
`185`	`185`	`or`
`186`	`186`	`result.asExpr() = this.getArgument(1) and type = CiphertextIO()`
`187`	`187`	`}`
`@@ -199,7 +199,7 @@ class EvpCipherFinalCall extends EvpCipherOperationFinalStep {`
`199`	`199`	`}`
`200`	`200`
`201`	`201`	`override DataFlow::Node getOutput(IOType type) {`
`202`		`- super.getInput(type) = result`
	`202`	`+ super.getOutput(type) = result`
`203`	`203`	`or`
`204`	`204`	`result.asDefiningArgument() = this.getArgument(1) and`
`205`	`205`	`type = CiphertextIO()`
`@@ -224,7 +224,7 @@ class EvpPKeyCipherOperation extends EvpCipherOperationFinalStep {`
`224`	`224`	`}`
`225`	`225`
`226`	`226`	`override DataFlow::Node getOutput(IOType type) {`
`227`		`- super.getInput(type) = result`
	`227`	`+ super.getOutput(type) = result`
`228`	`228`	`or`
`229`	`229`	`result.asExpr() = this.getArgument(1) and type = CiphertextIO()`
`230`	`230`	`// TODO: could indicate text lengths here, as well`