C++: Revert changes to cpp/constant-array-overflow

jketema · jketema · commit 75786e9a7138 · 2025-08-26T10:43:54.000+02:00
It is not clear that this does what we want here, and the query is severly
broken in any case.
diff --git a/cpp/ql/src/experimental/Security/CWE/CWE-193/ConstantSizeArrayOffByOne.ql b/cpp/ql/src/experimental/Security/CWE/CWE-193/ConstantSizeArrayOffByOne.ql
@@ -168,9 +168,9 @@ module ArrayAddressToDerefConfig implements DataFlow::StateConfigSig {
     )
   }
 
-  predicate isBarrierIn(DataFlow::Node node, FlowState state) { isSource(node, state) }
+  predicate isBarrierIn(DataFlow::Node node) { isSource(node, _) }
 
-  predicate isBarrierOut(DataFlow::Node node, FlowState state) { isSink(node, state) }
+  predicate isBarrierOut(DataFlow::Node node) { isSink(node, _) }
 
   predicate isAdditionalFlowStep(
     DataFlow::Node node1, FlowState state1, DataFlow::Node node2, FlowState state2

Original file line number	Diff line number	Diff line change
`@@ -168,9 +168,9 @@ module ArrayAddressToDerefConfig implements DataFlow::StateConfigSig {`
`168`	`168`	`)`
`169`	`169`	`}`
`170`	`170`
`171`		`- predicate isBarrierIn(DataFlow::Node node, FlowState state) { isSource(node, state) }`
	`171`	`+ predicate isBarrierIn(DataFlow::Node node) { isSource(node, _) }`
`172`	`172`
`173`		`- predicate isBarrierOut(DataFlow::Node node, FlowState state) { isSink(node, state) }`
	`173`	`+ predicate isBarrierOut(DataFlow::Node node) { isSink(node, _) }`
`174`	`174`
`175`	`175`	`predicate isAdditionalFlowStep(`
`176`	`176`	`DataFlow::Node node1, FlowState state1, DataFlow::Node node2, FlowState state2`