Skip to content

Commit 79039dc

Browse files
committed
Python: Wrap aiohttp client request in async def
And I added `await` before all the `resp` assignments
1 parent 14caaf1 commit 79039dc

File tree

1 file changed

+26
-26
lines changed

1 file changed

+26
-26
lines changed
Lines changed: 26 additions & 26 deletions
Original file line numberDiff line numberDiff line change
@@ -1,35 +1,35 @@
11
import aiohttp
2-
import asyncio
32
import ssl
43

5-
s = aiohttp.ClientSession()
6-
resp = s.request("method", "url") # $ clientRequestUrlPart="url"
7-
resp = s.request("method", url="url") # $ clientRequestUrlPart="url"
4+
async def test():
5+
s = aiohttp.ClientSession()
6+
resp = await s.request("method", "url") # $ clientRequestUrlPart="url"
7+
resp = await s.request("method", url="url") # $ clientRequestUrlPart="url"
88

9-
with aiohttp.ClientSession() as session:
10-
resp = session.get("url") # $ clientRequestUrlPart="url"
11-
resp = session.request(method="GET", url="url") # $ clientRequestUrlPart="url"
9+
with aiohttp.ClientSession() as session:
10+
resp = await session.get("url") # $ clientRequestUrlPart="url"
11+
resp = await session.request(method="GET", url="url") # $ clientRequestUrlPart="url"
1212

13-
# other methods than GET
14-
s = aiohttp.ClientSession()
15-
resp = s.post("url") # $ clientRequestUrlPart="url"
16-
resp = s.patch("url") # $ clientRequestUrlPart="url"
17-
resp = s.options("url") # $ clientRequestUrlPart="url"
13+
# other methods than GET
14+
s = aiohttp.ClientSession()
15+
resp = await s.post("url") # $ clientRequestUrlPart="url"
16+
resp = await s.patch("url") # $ clientRequestUrlPart="url"
17+
resp = await s.options("url") # $ clientRequestUrlPart="url"
1818

19-
# disabling of SSL validation
20-
# see https://docs.aiohttp.org/en/stable/client_reference.html#aiohttp.ClientSession.request
21-
s.get("url", ssl=False) # $ clientRequestUrlPart="url" clientRequestCertValidationDisabled
22-
s.get("url", ssl=0) # $ clientRequestUrlPart="url" clientRequestCertValidationDisabled
23-
# None is treated as default and so does _not_ disable the check
24-
s.get("url", ssl=None) # $ clientRequestUrlPart="url"
19+
# disabling of SSL validation
20+
# see https://docs.aiohttp.org/en/stable/client_reference.html#aiohttp.ClientSession.request
21+
s.get("url", ssl=False) # $ clientRequestUrlPart="url" clientRequestCertValidationDisabled
22+
s.get("url", ssl=0) # $ clientRequestUrlPart="url" clientRequestCertValidationDisabled
23+
# None is treated as default and so does _not_ disable the check
24+
s.get("url", ssl=None) # $ clientRequestUrlPart="url"
2525

26-
# deprecated since 3.0, but still supported
27-
s.get("url", verify_ssl=False) # $ clientRequestUrlPart="url" clientRequestCertValidationDisabled
26+
# deprecated since 3.0, but still supported
27+
s.get("url", verify_ssl=False) # $ clientRequestUrlPart="url" clientRequestCertValidationDisabled
2828

29-
# A manually constructed SSLContext does not have safe defaults, so is effectively the
30-
# same as turning off SSL validation
31-
context = ssl.SSLContext()
32-
assert context.check_hostname == False
33-
assert context.verify_mode == ssl.VerifyMode.CERT_NONE
29+
# A manually constructed SSLContext does not have safe defaults, so is effectively the
30+
# same as turning off SSL validation
31+
context = ssl.SSLContext()
32+
assert context.check_hostname == False
33+
assert context.verify_mode == ssl.VerifyMode.CERT_NONE
3434

35-
s.get("url", ssl=context) # $ clientRequestUrlPart="url" MISSING: clientRequestCertValidationDisabled
35+
s.get("url", ssl=context) # $ clientRequestUrlPart="url" MISSING: clientRequestCertValidationDisabled

0 commit comments

Comments
 (0)