Skip to content

Commit 7b4460e

Browse files
aibaarsadityasharad
andcommitted
Apply suggestions from code review
Co-authored-by: Aditya Sharad <[email protected]>
1 parent b9bf597 commit 7b4460e

File tree

3 files changed

+5
-4
lines changed

3 files changed

+5
-4
lines changed

.github/actions/fetch-codeql/action.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@ runs:
88
run: |
99
LATEST=$(gh release list --repo https://github.com/github/codeql-cli-binaries | cut -f 1 | grep -v beta | sort --version-sort | tail -1)
1010
gh release download --repo https://github.com/github/codeql-cli-binaries --pattern codeql-linux64.zip "$LATEST"
11-
unzip -q -d "${{ runner.temp }}" codeql-linux64.zip
12-
echo "${{ runner.temp }}/codeql" >> $GITHUB_PATH
11+
unzip -q -d "${RUNNER_TEMP}" codeql-linux64.zip
12+
echo "${RUNNER_TEMP}/codeql" >> "${GITHUB_PATH}"
1313
env:
1414
GITHUB_TOKEN: ${{ github.token }}

.github/workflows/post-pr-comment.yml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -22,6 +22,7 @@ jobs:
2222
PR_HEAD_SHA="$(gh api "/repos/${GITHUB_REPOSITORY}/pulls/${PR}" --jq .head.sha)"
2323
# Check that the pull-request head SHA matches the head SHA of the workflow run
2424
if [ "${WORKFLOW_RUN_HEAD_SHA}" != "${PR_HEAD_SHA}" ]; then
25+
echo "PR head SHA ${PR_HEAD_SHA} does not match workflow_run event SHA ${WORKFLOW_RUN_HEAD_SHA}. Stopping." 1>&2
2526
exit 1
2627
fi
2728
gh pr comment "${PR}" --repo "${GITHUB_REPOSITORY}" -F comment.txt

.github/workflows/qhelp-pr-preview.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -31,7 +31,7 @@ jobs:
3131
run: |
3232
(git diff -z --name-only --diff-filter=ACMRT HEAD~1 HEAD | grep -z '.qhelp$' | grep -z -v '.inc.qhelp';
3333
git diff -z --name-only --diff-filter=ACMRT HEAD~1 HEAD | grep -z '.inc.qhelp$' | xargs --null -rn1 basename | xargs --null -rn1 git grep -z -l) |
34-
grep -z '.qhelp$' | grep -z -v '^-' | sort -z -u > "${{ runner.temp }}/paths.txt"
34+
grep -z '.qhelp$' | grep -z -v '^-' | sort -z -u > "${RUNNER_TEMP}/paths.txt"
3535
3636
- name: QHelp preview
3737
run: |
@@ -52,7 +52,7 @@ jobs:
5252
echo '```'
5353
fi
5454
echo "</details>"
55-
done < "${{ runner.temp }}/paths.txt" >> comment.txt
55+
done < "${RUNNER_TEMP}/paths.txt" >> comment.txt
5656
exit "${EXIT_CODE}"
5757
5858
- if: always()

0 commit comments

Comments
 (0)