Java insecure cookies query: look through named constants

smowton · smowton · commit 7d4767a4f573 · 2022-04-26T10:32:13.000+01:00
diff --git a/java/ql/src/Security/CWE/CWE-614/InsecureCookie.ql b/java/ql/src/Security/CWE/CWE-614/InsecureCookie.ql
@@ -20,7 +20,7 @@ where
   not exists(Variable cookie, MethodAccess m |
     add.getArgument(0) = cookie.getAnAccess() and
     m.getMethod().getName() = "setSecure" and
-    m.getArgument(0).(BooleanLiteral).getBooleanValue() = true and
+    m.getArgument(0).(CompileTimeConstantExpr).getBooleanValue() = true and
     m.getQualifier() = cookie.getAnAccess()
   )
 select add, "Cookie is added to response without the 'secure' flag being set."

Original file line number	Diff line number	Diff line change
`@@ -20,7 +20,7 @@ where`
`20`	`20`	`not exists(Variable cookie, MethodAccess m \|`
`21`	`21`	`add.getArgument(0) = cookie.getAnAccess() and`
`22`	`22`	`m.getMethod().getName() = "setSecure" and`
`23`		`- m.getArgument(0).(BooleanLiteral).getBooleanValue() = true and`
	`23`	`+ m.getArgument(0).(CompileTimeConstantExpr).getBooleanValue() = true and`
`24`	`24`	`m.getQualifier() = cookie.getAnAccess()`
`25`	`25`	`)`
`26`	`26`	`select add, "Cookie is added to response without the 'secure' flag being set."`