C#: ExternalAPIsQuery/UntrustedDataToExternalAPI

d10c · d10c · commit 7d9e3fc49bd2 · 2025-07-04T11:48:04.000+02:00
diff --git a/csharp/ql/lib/semmle/code/csharp/security/dataflow/ExternalAPIsQuery.qll b/csharp/ql/lib/semmle/code/csharp/security/dataflow/ExternalAPIsQuery.qll
@@ -79,9 +79,7 @@ private module RemoteSourceToExternalApiConfig implements DataFlow::ConfigSig {
 
   predicate isSink(DataFlow::Node sink) { sink instanceof ExternalApiDataNode }
 
-  predicate observeDiffInformedIncrementalMode() {
-    any() // TODO: Make sure that the location overrides match the query's select clause: Flow call outside 'select' clause (/Users/d10c/src/semmle-code/ql/csharp/ql/lib/semmle/code/csharp/security/dataflow/ExternalAPIsQuery.qll@88:36:88:75), Flow call outside 'select' clause (/Users/d10c/src/semmle-code/ql/csharp/ql/lib/semmle/code/csharp/security/dataflow/ExternalAPIsQuery.qll@91:43:91:87)
-  }
+  predicate observeDiffInformedIncrementalMode() { any() }
 }
 
 /** A module for tracking flow from `ActiveThreatModelSource`s to `ExternalApiDataNode`s. */

Original file line number	Diff line number	Diff line change
`@@ -79,9 +79,7 @@ private module RemoteSourceToExternalApiConfig implements DataFlow::ConfigSig {`
`79`	`79`
`80`	`80`	`predicate isSink(DataFlow::Node sink) { sink instanceof ExternalApiDataNode }`
`81`	`81`
`82`		`- predicate observeDiffInformedIncrementalMode() {`
`83`		`- any() // TODO: Make sure that the location overrides match the query's select clause: Flow call outside 'select' clause (/Users/d10c/src/semmle-code/ql/csharp/ql/lib/semmle/code/csharp/security/dataflow/ExternalAPIsQuery.qll@88:36:88:75), Flow call outside 'select' clause (/Users/d10c/src/semmle-code/ql/csharp/ql/lib/semmle/code/csharp/security/dataflow/ExternalAPIsQuery.qll@91:43:91:87)`
`84`		`- }`
	`82`	`+ predicate observeDiffInformedIncrementalMode() { any() }`
`85`	`83`	`}`
`86`	`84`
`87`	`85`	/** A module for tracking flow from `ActiveThreatModelSource`s to `ExternalApiDataNode`s. */