Remove unnecessary AdditionalValueStep check

ebickle · ebickle · commit 80c8259e3428 · 2023-10-10T09:35:45.000-07:00
diff --git a/java/ql/src/experimental/Security/CWE/CWE-400/ThreadResourceAbuse.ql b/java/ql/src/experimental/Security/CWE/CWE-400/ThreadResourceAbuse.ql
@@ -22,7 +22,6 @@ module ThreadResourceAbuseConfig implements DataFlow::ConfigSig {
   predicate isSink(DataFlow::Node sink) { sink instanceof PauseThreadSink }
 
   predicate isAdditionalFlowStep(DataFlow::Node pred, DataFlow::Node succ) {
-    any(AdditionalValueStep r).step(pred, succ) or
     any(ThreadResourceAbuseAdditionalTaintStep c).step(pred, succ)
   }
 

Original file line number	Diff line number	Diff line change
`@@ -22,7 +22,6 @@ module ThreadResourceAbuseConfig implements DataFlow::ConfigSig {`
`22`	`22`	`predicate isSink(DataFlow::Node sink) { sink instanceof PauseThreadSink }`
`23`	`23`
`24`	`24`	`predicate isAdditionalFlowStep(DataFlow::Node pred, DataFlow::Node succ) {`
`25`		`- any(AdditionalValueStep r).step(pred, succ) or`
`26`	`25`	`any(ThreadResourceAbuseAdditionalTaintStep c).step(pred, succ)`
`27`	`26`	`}`
`28`	`27`