Minor simplification of finderMethodName predicate

alexrford · alexrford · commit 8262247ed71e · 2021-10-07T15:30:36.000+01:00
diff --git a/ql/lib/codeql/ruby/frameworks/ActiveRecord.qll b/ql/lib/codeql/ruby/frameworks/ActiveRecord.qll
@@ -262,7 +262,7 @@ private string finderMethodName() {
         "fifth", "find", "find_by", "find_or_initialize_by", "find_or_create_by", "first",
         "forty_two", "fourth", "last", "second", "second_to_last", "take", "third", "third_to_last"
       ] and
-    (result = baseName or result = baseName + "!")
+    result = baseName + ["", "!"]
   )
   or
   result = "new"

Original file line number	Diff line number	Diff line change
`@@ -262,7 +262,7 @@ private string finderMethodName() {`
`262`	`262`	`"fifth", "find", "find_by", "find_or_initialize_by", "find_or_create_by", "first",`
`263`	`263`	`"forty_two", "fourth", "last", "second", "second_to_last", "take", "third", "third_to_last"`
`264`	`264`	`] and`
`265`		`- (result = baseName or result = baseName + "!")`
	`265`	`+ result = baseName + ["", "!"]`
`266`	`266`	`)`
`267`	`267`	`or`
`268`	`268`	`result = "new"`