remove redundant cast

erik-krogh · alexrford · web-flow · commit 844e78dce510 · 2024-04-10T20:02:49.000+02:00
Co-authored-by: Alex Ford &lt;alexrford@users.noreply.github.com&gt;
diff --git a/ruby/ql/lib/codeql/ruby/ast/internal/Constant.qll b/ruby/ql/lib/codeql/ruby/ast/internal/Constant.qll
@@ -562,7 +562,6 @@ private predicate isArrayExpr(Expr e, ArrayLiteralCfgNode arr) {
   forex(ExprCfgNode n | n = e.getAControlFlowNode() | isArrayConstant(n, arr))
   or
   // if `e` is an array, then `e.freeze` is also an array
-  e instanceof MethodCall and
   e.(MethodCall).getMethodName() = "freeze" and
   isArrayExpr(e.(MethodCall).getReceiver(), arr)
 }

Original file line number	Diff line number	Diff line change
`@@ -562,7 +562,6 @@ private predicate isArrayExpr(Expr e, ArrayLiteralCfgNode arr) {`
`562`	`562`	`forex(ExprCfgNode n \| n = e.getAControlFlowNode() \| isArrayConstant(n, arr))`
`563`	`563`	`or`
`564`	`564`	// if `e` is an array, then `e.freeze` is also an array
`565`		`- e instanceof MethodCall and`
`566`	`565`	`e.(MethodCall).getMethodName() = "freeze" and`
`567`	`566`	`isArrayExpr(e.(MethodCall).getReceiver(), arr)`
`568`	`567`	`}`