Skip to content

Commit 84d1d72

Browse files
atorralbasmowton
andcommitted
Apply suggestions from code review
Co-authored-by: Chris Smowton <[email protected]>
1 parent 750c808 commit 84d1d72

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

go/ql/lib/semmle/go/security/HardcodedCredentials.qll

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -47,7 +47,7 @@ module HardcodedCredentials {
4747

4848
/**
4949
* Holds if the guard `g` in its branch `branch` validates the expression `e`
50-
* by comparing it to a disallowed literal.
50+
* by comparing it to a literal.
5151
*/
5252
private predicate constantValueCheck(DataFlow::Node g, Expr e, boolean branch) {
5353
exists(Literal lit, DataFlow::EqualityTestNode eq | eq = g |
@@ -59,7 +59,7 @@ module HardcodedCredentials {
5959
}
6060

6161
/**
62-
* A value validated by comparing it to a disallowed constant value.
62+
* A value validated by comparing it to a constant value.
6363
* For example, in the context `if key != "invalid_key" { ... }`,
6464
* if `"invalid_key"` is indeed the only dangerous key then guarded uses of `key` are likely
6565
* to be safe.

0 commit comments

Comments
 (0)