Skip to content

Commit 8601105

Browse files
committed
Python: Address TODO comment
1 parent e1bf282 commit 8601105

File tree

1 file changed

+3
-1
lines changed

1 file changed

+3
-1
lines changed

python/ql/lib/semmle/python/dataflow/new/internal/VariableCapture.qll

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,9 @@ private module CaptureInput implements Shared::InputSig<Location> {
2929
class BasicBlock extends PY::BasicBlock {
3030
Callable getEnclosingCallable() { result = this.getScope() }
3131

32-
// TODO: check that this gives useful results
32+
// Note `PY:BasicBlock` does not have a `GetLocation` and
33+
// has a more complicated location info logic.
34+
// This is good enough for here.
3335
Location getLocation() { result = super.getNode(0).getLocation() }
3436
}
3537

0 commit comments

Comments
 (0)