C++: Use 'asDefinition' instead of checking for a 'Store' instruction.

MathiasVP · MathiasVP · commit 8630630c4541 · 2024-04-16T11:00:57.000+01:00
diff --git a/cpp/ql/lib/semmle/code/cpp/ir/dataflow/internal/DataFlowPrivate.qll b/cpp/ql/lib/semmle/code/cpp/ir/dataflow/internal/DataFlowPrivate.qll
@@ -1011,7 +1011,9 @@ predicate nodeIsHidden(Node n) {
 
 predicate neverSkipInPathGraph(Node n) {
   // Always show the right-hand side of assignments in the path graph
-  nodeHasOperand(n, any(StoreInstruction store).getSourceValueOperand(), _)
+  exists(n.asDefinition())
+  or
+  exists(n.asIndirectDefinition())
 }
 
 class LambdaCallKind = Unit;

Original file line number	Diff line number	Diff line change
`@@ -1011,7 +1011,9 @@ predicate nodeIsHidden(Node n) {`
`1011`	`1011`
`1012`	`1012`	`predicate neverSkipInPathGraph(Node n) {`
`1013`	`1013`	`// Always show the right-hand side of assignments in the path graph`
`1014`		`- nodeHasOperand(n, any(StoreInstruction store).getSourceValueOperand(), _)`
	`1014`	`+ exists(n.asDefinition())`
	`1015`	`+ or`
	`1016`	`+ exists(n.asIndirectDefinition())`
`1015`	`1017`	`}`
`1016`	`1018`
`1017`	`1019`	`class LambdaCallKind = Unit;`