Skip to content

Commit 8707a63

Browse files
committed
Python: Add comments around storeStepCommon
1 parent 20202ab commit 8707a63

File tree

1 file changed

+7
-0
lines changed

1 file changed

+7
-0
lines changed

python/ql/lib/semmle/python/dataflow/new/internal/DataFlowPrivate.qll

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -643,6 +643,13 @@ predicate jumpStepNotSharedWithTypeTracker(Node nodeFrom, Node nodeTo) {
643643
//--------
644644
/**
645645
* Subset of `storeStep` that should be shared with type-tracking.
646+
*
647+
* NOTE: This does not include attributeStoreStep right now, since it has its' own
648+
* modeling in the type-tracking library (which is slightly different due to
649+
* PostUpdateNodes).
650+
*
651+
* As of 2024-04-02 the type-tracking library only supports precise content, so there is
652+
* no reason to include steps for list content right now.
646653
*/
647654
predicate storeStepCommon(Node nodeFrom, ContentSet c, Node nodeTo) {
648655
tupleStoreStep(nodeFrom, c, nodeTo)

0 commit comments

Comments
 (0)