C++: Correct the doc.

geoffw0 · geoffw0 · commit 88fb1a18cbe8 · 2021-11-29T13:09:12.000Z
diff --git a/cpp/ql/src/Security/CWE/CWE-295/SSLResultNotCheckedBad.cpp b/cpp/ql/src/Security/CWE/CWE-295/SSLResultNotCheckedBad.cpp
@@ -1,5 +1,5 @@
 // ...
 
-int cert = SSL_get_peer_certificate(ssl); // BAD (SSL_get_verify_result is never called)
+X509 *cert = SSL_get_peer_certificate(ssl); // BAD (SSL_get_verify_result is never called)
 
 // ...
diff --git a/cpp/ql/src/Security/CWE/CWE-295/SSLResultNotCheckedGood.cpp b/cpp/ql/src/Security/CWE/CWE-295/SSLResultNotCheckedGood.cpp
@@ -1,6 +1,6 @@
 // ...
 
-int cert = SSL_get_peer_certificate(ssl); // GOOD
+X509 *cert = SSL_get_peer_certificate(ssl); // GOOD
 if (cert)
 {
 	result = SSL_get_verify_result(ssl);

-Original file line number
+Diff line change
@@ @@ -1,5 +1,5 @@ @@
 // ...
 -int cert = SSL_get_peer_certificate(ssl); // BAD (SSL_get_verify_result is never called)
 +X509 *cert = SSL_get_peer_certificate(ssl); // BAD (SSL_get_verify_result is never called)
 // ...
Original file line number	Diff line number	Diff line change
`@@ -1,6 +1,6 @@`
`1`	`1`	`// ...`
`2`	`2`
`3`		`-int cert = SSL_get_peer_certificate(ssl); // GOOD`
	`3`	`+X509 *cert = SSL_get_peer_certificate(ssl); // GOOD`
`4`	`4`	`if (cert)`
`5`	`5`	`{`
`6`	`6`	`result = SSL_get_verify_result(ssl);`