Skip to content

Commit 8b4e060

Browse files
authored
Merge pull request #17199 from github/8456-remove-old-references
Remove references to a deprecated data flow library for C/C++
2 parents 993bfee + dc0832c commit 8b4e060

File tree

6 files changed

+161
-549
lines changed

6 files changed

+161
-549
lines changed

docs/codeql/codeql-language-guides/advanced-dataflow-scenarios-cpp.rst

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,5 @@
11
.. _advanced-dataflow-scenarios-cpp:
22

3-
.. include:: ../reusables/cpp-new-dataflow-api-note.rst
4-
53
Advanced dataflow scenarios for C/C++
64
======================================
75

@@ -102,7 +100,7 @@ This data flow is simple to match because the CodeQL database contains the infor
102100
Flow from a qualifier to a field access
103101
---------------------------------------
104102

105-
Sometimes field accesses are not visible to CodeQL (for example, because the implementation of the function isn't included in the database), and so dataflow cannot match up all stores with reads. This leads to missing (false negative) results.
103+
Sometimes field accesses are not visible to CodeQL (for example, because the implementation of the function isn't included in the database), and so dataflow cannot match up all stores with reads. This leads to missing (false negative) results.
106104

107105
For example, consider an alternative setup where our source of data starts as the outgoing argument of a function ``write_user_input_to``. We can model this setup in the dataflow library using the following ``isSource``:
108106

@@ -456,4 +454,4 @@ The ``allowImplicitRead`` predicate specifies that if we're at a node that satis
456454
3. The data flowing to the indirection of ``&b`` (i.e., the object ``b``).
457455
4. An implicit read of the field ``x`` followed by an implicit read of the field ``a`` at the sink.
458456

459-
Thus, we end up at a node that satisfies ``isSink`` with an empty access path, and successfully track the full dataflow path.
457+
Thus, we end up at a node that satisfies ``isSink`` with an empty access path, and successfully track the full dataflow path.

0 commit comments

Comments
 (0)