Skip to content

Commit 8f714c6

Browse files
joefarebrotheryoff
andauthored
Code reveiw suggestions. correction in changenote + style in example
Co-authored-by: yoff <[email protected]>
1 parent db27fd9 commit 8f714c6

File tree

2 files changed

+2
-2
lines changed

2 files changed

+2
-2
lines changed

python/ql/src/Security/CWE-614/examples/InsecureCookie.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,5 +16,5 @@ def good2():
1616

1717
@app.route("/bad1")
1818
resp = make_response()
19-
resp.set_cookie("name", value="value", samesite='None') # BAD: the SameSite attribute is set to 'None'; and the 'Secure' and 'HttpOnly' attributes are set to False by default.
19+
resp.set_cookie("name", value="value", samesite='None') # BAD: the SameSite attribute is set to 'None' and the 'Secure' and 'HttpOnly' attributes are set to False by default.
2020
return resp
Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
11
---
22
category: newQuery
33
---
4-
* The `py/cookie-injection` query, originally contributed to the experimental query pack by @jorgectf, has been promoted to the main query pack. This query finds instances of securities being set without the `Secure`, `HttpOnly`, or `SameSite` attributes set to secure values.
4+
* The `py/cookie-injection` query, originally contributed to the experimental query pack by @jorgectf, has been promoted to the main query pack. This query finds instances of cookies being set without the `Secure`, `HttpOnly`, or `SameSite` attributes set to secure values.

0 commit comments

Comments
 (0)