Skip to content

Commit 90baef8

Browse files
committed
C#: Add flow summaries for another TryParse method in System.Boolean.
1 parent 8eb041c commit 90baef8

File tree

3 files changed

+7
-1
lines changed

3 files changed

+7
-1
lines changed

csharp/ql/lib/semmle/code/csharp/frameworks/System.qll

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -99,7 +99,9 @@ private class SystemBoolean32FlowModelCsv extends SummaryModelCsv {
9999
[
100100
"System;Boolean;false;Parse;(System.String);;Argument[0];ReturnValue;taint",
101101
"System;Boolean;false;TryParse;(System.String,System.Boolean);;Argument[0];Argument[1];taint",
102-
"System;Boolean;false;TryParse;(System.String,System.Boolean);;Argument[0];ReturnValue;taint"
102+
"System;Boolean;false;TryParse;(System.String,System.Boolean);;Argument[0];ReturnValue;taint",
103+
"System;Boolean;false;TryParse;(System.ReadOnlySpan<System.Char>,System.Boolean);;Element of Argument[0];Argument[1];taint",
104+
"System;Boolean;false;TryParse;(System.ReadOnlySpan<System.Char>,System.Boolean);;Element of Argument[0];ReturnValue;taint",
103105
]
104106
}
105107
}

csharp/ql/test/library-tests/dataflow/library/FlowSummaries.expected

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2330,6 +2330,8 @@
23302330
| System;Array;false;get_Item;(System.Int32);;Element of Argument[-1];ReturnValue;value |
23312331
| System;Array;false;set_Item;(System.Int32,System.Object);;Argument[1];Element of Argument[-1];value |
23322332
| System;Boolean;false;Parse;(System.String);;Argument[0];ReturnValue;taint |
2333+
| System;Boolean;false;TryParse;(System.ReadOnlySpan<System.Char>,System.Boolean);;Element of Argument[0];Argument[1];taint |
2334+
| System;Boolean;false;TryParse;(System.ReadOnlySpan<System.Char>,System.Boolean);;Element of Argument[0];ReturnValue;taint |
23332335
| System;Boolean;false;TryParse;(System.String,System.Boolean);;Argument[0];Argument[1];taint |
23342336
| System;Boolean;false;TryParse;(System.String,System.Boolean);;Argument[0];ReturnValue;taint |
23352337
| System;Convert;false;ChangeType;(System.Object,System.Type);;Argument[0];ReturnValue;taint |

csharp/ql/test/library-tests/dataflow/library/FlowSummariesFiltered.expected

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2004,6 +2004,8 @@
20042004
| System;Array;false;get_Item;(System.Int32);;Element of Argument[-1];ReturnValue;value |
20052005
| System;Array;false;set_Item;(System.Int32,System.Object);;Argument[1];Element of Argument[-1];value |
20062006
| System;Boolean;false;Parse;(System.String);;Argument[0];ReturnValue;taint |
2007+
| System;Boolean;false;TryParse;(System.ReadOnlySpan<System.Char>,System.Boolean);;Element of Argument[0];Argument[1];taint |
2008+
| System;Boolean;false;TryParse;(System.ReadOnlySpan<System.Char>,System.Boolean);;Element of Argument[0];ReturnValue;taint |
20072009
| System;Boolean;false;TryParse;(System.String,System.Boolean);;Argument[0];Argument[1];taint |
20082010
| System;Boolean;false;TryParse;(System.String,System.Boolean);;Argument[0];ReturnValue;taint |
20092011
| System;Convert;false;ChangeType;(System.Object,System.Type);;Argument[0];ReturnValue;taint |

0 commit comments

Comments
 (0)