Skip to content

Commit 90bc138

Browse files
committed
CPP: Fix QLDoc comments.
1 parent a3de94e commit 90bc138

File tree

1 file changed

+3
-1
lines changed

1 file changed

+3
-1
lines changed

cpp/ql/src/Security/CWE/CWE-311/CleartextTransmission.ql

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -35,7 +35,7 @@ abstract class NetworkSendRecv extends FunctionCall {
3535
/**
3636
* A function call that sends data over a network.
3737
*
38-
* note: functions such as `read` may be reading from a network source or a file. We could attempt to determine which, and sort results into `cpp/cleartext-transmission` and perhaps `cpp/cleartext-storage-file`. In practice it probably isn't very important which query reports a result as long as its reported exactly once.
38+
* note: functions such as `write` may be writing to a network source or a file. We could attempt to determine which, and sort results into `cpp/cleartext-transmission` and perhaps `cpp/cleartext-storage-file`. In practice it usually isn't very important which query reports a result as long as its reported exactly once.
3939
*/
4040
class NetworkSend extends NetworkSendRecv {
4141
NetworkSend() {
@@ -76,6 +76,8 @@ class SensitiveSendRecvConfiguration extends TaintTracking::Configuration {
7676
override predicate isSink(DataFlow::Node sink) {
7777
exists(NetworkSendRecv transmission |
7878
sink.asExpr() = transmission.getDataExpr() and
79+
80+
// a zero file descriptor is standard input, which is not interesting for this query.
7981
not exists(Zero zero |
8082
DataFlow::localFlow(DataFlow::exprNode(zero),
8183
DataFlow::exprNode(transmission.getSocketExpr()))

0 commit comments

Comments
 (0)