Skip to content

Commit 91a98f3

Browse files
committed
C++: Accept new dataflow IR inconsistencies
These are due to additional loads being generated on fields, and should not cause any problems. Ideally, we should tune the definition of `TPostFieldUpdateNode` to make these go away.
1 parent 231e9ef commit 91a98f3

File tree

2 files changed

+6
-0
lines changed

2 files changed

+6
-0
lines changed

cpp/ql/test/library-tests/dataflow/dataflow-tests/dataflow-ir-consistency.expected

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -14,6 +14,9 @@ localCallNodes
1414
postIsNotPre
1515
postHasUniquePre
1616
uniquePostUpdate
17+
| example.c:24:2:24:7 | coords indirection | Node has multiple PostUpdateNodes. |
18+
| example.c:24:13:24:18 | coords indirection | Node has multiple PostUpdateNodes. |
19+
| example.c:26:2:26:7 | coords indirection | Node has multiple PostUpdateNodes. |
1720
postIsInSameCallable
1821
reverseRead
1922
argHasPostUpdate

cpp/ql/test/library-tests/syntax-zoo/dataflow-ir-consistency.expected

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -15,6 +15,7 @@ localCallNodes
1515
postIsNotPre
1616
postHasUniquePre
1717
uniquePostUpdate
18+
| allocators.cpp:4:24:4:26 | this indirection | Node has multiple PostUpdateNodes. |
1819
| cpp11.cpp:82:17:82:17 | this indirection | Node has multiple PostUpdateNodes. |
1920
| cpp11.cpp:82:17:82:55 | [...](...){...} indirection | Node has multiple PostUpdateNodes. |
2021
| ir.cpp:514:10:514:11 | definition of r2 indirection | Node has multiple PostUpdateNodes. |
@@ -31,6 +32,8 @@ uniquePostUpdate
3132
| ir.cpp:777:3:777:11 | this indirection | Node has multiple PostUpdateNodes. |
3233
| ir.cpp:786:3:786:11 | this indirection | Node has multiple PostUpdateNodes. |
3334
| ir.cpp:795:3:795:11 | this indirection | Node has multiple PostUpdateNodes. |
35+
| misc.c:130:5:130:5 | s indirection | Node has multiple PostUpdateNodes. |
36+
| misc.c:131:5:131:6 | sp indirection | Node has multiple PostUpdateNodes. |
3437
| static_init_templates.cpp:240:7:240:7 | this indirection | Node has multiple PostUpdateNodes. |
3538
postIsInSameCallable
3639
reverseRead

0 commit comments

Comments
 (0)