Skip to content

Commit 929f6ca

Browse files
committed
C#: Address review comments.
1 parent d3368dc commit 929f6ca

File tree

2 files changed

+2
-3
lines changed

2 files changed

+2
-3
lines changed

csharp/ql/lib/semmle/code/csharp/dataflow/FlowSummary.qll

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -159,7 +159,7 @@ private class RecordConstructorFlowRequiredSummaryComponentStack extends Require
159159
exists(Property p |
160160
recordConstructorFlow(_, _, p) and
161161
head = SummaryComponent::property(p) and
162-
this = SummaryComponentStack::singleton(SummaryComponent::return())
162+
this = SummaryComponentStack::return()
163163
)
164164
}
165165

csharp/ql/lib/semmle/code/csharp/frameworks/system/Text.qll

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -29,8 +29,7 @@ class SystemTextStringBuilderClass extends SystemTextClass {
2929
/** Clear content for `System.Text.StringBuilder.Clear`. */
3030
private class SystemTextStringBuilderClearFlow extends SummarizedCallable {
3131
SystemTextStringBuilderClearFlow() {
32-
this.getDeclaringType() instanceof SystemTextStringBuilderClass and
33-
this.hasName("Clear")
32+
this = any(SystemTextStringBuilderClass s).getAMethod("Clear")
3433
}
3534

3635
override predicate clearsContent(ParameterPosition pos, DataFlow::Content content) {

0 commit comments

Comments
 (0)