Skip to content

Commit 9302b16

Browse files
committed
C++: Fix further merge conflicts.
1 parent e13b3ed commit 9302b16

File tree

2 files changed

+11
-8
lines changed

2 files changed

+11
-8
lines changed

cpp/ql/lib/semmle/code/cpp/dataflow/ExternalFlow.qll

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -471,7 +471,7 @@ private module Cached {
471471
cached
472472
predicate sourceNode(DataFlow::Node node, string kind) {
473473
exists(SourceSinkInterpretationInput::InterpretNode n |
474-
isSourceNode(n, kind) and n.asNode() = node
474+
isSourceNode(n, kind, _) and n.asNode() = node // TODO
475475
)
476476
}
477477

@@ -482,7 +482,7 @@ private module Cached {
482482
cached
483483
predicate sinkNode(DataFlow::Node node, string kind) {
484484
exists(SourceSinkInterpretationInput::InterpretNode n |
485-
isSinkNode(n, kind) and n.asNode() = node
485+
isSinkNode(n, kind, _) and n.asNode() = node // TODO
486486
)
487487
}
488488
}
@@ -518,15 +518,16 @@ private class SummarizedCallableAdapter extends SummarizedCallable {
518518
)
519519
}
520520

521-
override predicate propagatesFlow(string input, string output, boolean preservesValue) {
521+
override predicate propagatesFlow(string input, string output, boolean preservesValue, string model) {
522522
exists(string kind |
523523
this.relevantSummaryElementManual(input, output, kind)
524524
or
525525
not this.relevantSummaryElementManual(_, _, _) and
526526
this.relevantSummaryElementGenerated(input, output, kind)
527527
|
528528
if kind = "value" then preservesValue = true else preservesValue = false
529-
)
529+
) and
530+
model = "" // TODO
530531
}
531532

532533
override predicate hasProvenance(Provenance provenance) {

cpp/ql/lib/semmle/code/cpp/dataflow/internal/FlowSummaryImpl.qll

Lines changed: 6 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -120,13 +120,14 @@ module SourceSinkInterpretationInput implements
120120
* `output`, kind `kind`, and provenance `provenance`.
121121
*/
122122
predicate sourceElement(
123-
SourceOrSinkElement e, string output, string kind, Public::Provenance provenance
123+
SourceOrSinkElement e, string output, string kind, Public::Provenance provenance, string model
124124
) {
125125
exists(
126126
string namespace, string type, boolean subtypes, string name, string signature, string ext
127127
|
128128
sourceModel(namespace, type, subtypes, name, signature, ext, output, kind, provenance) and
129-
e = interpretElement(namespace, type, subtypes, name, signature, ext)
129+
e = interpretElement(namespace, type, subtypes, name, signature, ext) and
130+
model = "" // TODO
130131
)
131132
}
132133

@@ -135,13 +136,14 @@ module SourceSinkInterpretationInput implements
135136
* `input`, kind `kind` and provenance `provenance`.
136137
*/
137138
predicate sinkElement(
138-
SourceOrSinkElement e, string input, string kind, Public::Provenance provenance
139+
SourceOrSinkElement e, string input, string kind, Public::Provenance provenance, string model
139140
) {
140141
exists(
141142
string package, string type, boolean subtypes, string name, string signature, string ext
142143
|
143144
sinkModel(package, type, subtypes, name, signature, ext, input, kind, provenance) and
144-
e = interpretElement(package, type, subtypes, name, signature, ext)
145+
e = interpretElement(package, type, subtypes, name, signature, ext) and
146+
model = "" // TODO
145147
)
146148
}
147149

0 commit comments

Comments
 (0)