Skip to content

Commit 938176c

Browse files
committed
C++: update test QL for modulus and sign analysis
These now instantiate their respective parameterized modules. No results change.
1 parent 7586762 commit 938176c

File tree

2 files changed

+16
-2
lines changed

2 files changed

+16
-2
lines changed

cpp/ql/test/library-tests/ir/modulus-analysis/ModulusAnalysis.ql

Lines changed: 8 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,16 @@
11
import cpp
22
import experimental.semmle.code.cpp.semantic.analysis.ModulusAnalysis
33
import experimental.semmle.code.cpp.semantic.Semantic
4+
import experimental.semmle.code.cpp.semantic.analysis.RangeUtils
5+
import experimental.semmle.code.cpp.semantic.analysis.FloatDelta
6+
import experimental.semmle.code.cpp.semantic.analysis.RangeAnalysisSpecific
7+
import experimental.semmle.code.cpp.semantic.analysis.RangeAnalysis
48
import semmle.code.cpp.ir.IR as IR
59
import TestUtilities.InlineExpectationsTest
610

11+
module ModulusAnalysisInstantiated =
12+
ModulusAnalysis<FloatDelta, Bounds, RangeUtil<FloatDelta, CppLangImpl>>;
13+
714
class ModulusAnalysisTest extends InlineExpectationsTest {
815
ModulusAnalysisTest() { this = "ModulusAnalysisTest" }
916

@@ -23,7 +30,7 @@ class ModulusAnalysisTest extends InlineExpectationsTest {
2330

2431
private string getAModString(SemExpr e) {
2532
exists(SemBound b, int delta, int mod |
26-
semExprModulus(e, b, delta, mod) and
33+
ModulusAnalysisInstantiated::semExprModulus(e, b, delta, mod) and
2734
result = b.toString() + "," + delta.toString() + "," + mod.toString() and
2835
not (delta = 0 and mod = 0)
2936
)

cpp/ql/test/library-tests/ir/sign-analysis/SignAnalysis.ql

Lines changed: 8 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,14 @@
11
import cpp
22
import experimental.semmle.code.cpp.semantic.analysis.SignAnalysisCommon
33
import experimental.semmle.code.cpp.semantic.Semantic
4+
import experimental.semmle.code.cpp.semantic.analysis.RangeUtils
5+
import experimental.semmle.code.cpp.semantic.analysis.FloatDelta
6+
import experimental.semmle.code.cpp.semantic.analysis.RangeAnalysisSpecific
47
import semmle.code.cpp.ir.IR as IR
58
import TestUtilities.InlineExpectationsTest
69

10+
module SignAnalysisInstantiated = SignAnalysis<FloatDelta, RangeUtil<FloatDelta, CppLangImpl>>;
11+
712
class SignAnalysisTest extends InlineExpectationsTest {
813
SignAnalysisTest() { this = "SignAnalysisTest" }
914

@@ -21,4 +26,6 @@ class SignAnalysisTest extends InlineExpectationsTest {
2126
}
2227
}
2328

24-
private string getASignString(SemExpr e) { result = strictconcat(semExprSign(e).toString(), "") }
29+
private string getASignString(SemExpr e) {
30+
result = strictconcat(SignAnalysisInstantiated::semExprSign(e).toString(), "")
31+
}

0 commit comments

Comments
 (0)