Update ruby/ql/src/experimental/cwe-208/UnsafeHmacComparison.ql

boveus · alexrford · web-flow · commit 93dd9d0aa4d6 · 2023-08-08T12:54:54.000-04:00
Co-authored-by: Alex Ford &lt;alexrford@users.noreply.github.com&gt;
diff --git a/ruby/ql/src/experimental/cwe-208/UnsafeHmacComparison.ql b/ruby/ql/src/experimental/cwe-208/UnsafeHmacComparison.ql
@@ -54,11 +54,7 @@ class Configuration extends DataFlow::Configuration {
 
   // Holds if a given sink is an Equality Operation (== or !=)
   override predicate isSink(DataFlow::Node sink) {
-    exists(EqualityOperation eqOp |
-      eqOp.getLeftOperand() = sink.asExpr().getExpr()
-      or
-      eqOp.getRightOperand() = sink.asExpr().getExpr()
-    )
+    any(EqualityOperation eqOp).getAnOperand() = sink.asExpr().getExpr()
   }
 }
 

Original file line number	Diff line number	Diff line change
`@@ -54,11 +54,7 @@ class Configuration extends DataFlow::Configuration {`
`54`	`54`
`55`	`55`	`// Holds if a given sink is an Equality Operation (== or !=)`
`56`	`56`	`override predicate isSink(DataFlow::Node sink) {`
`57`		`- exists(EqualityOperation eqOp \|`
`58`		`- eqOp.getLeftOperand() = sink.asExpr().getExpr()`
`59`		`- or`
`60`		`- eqOp.getRightOperand() = sink.asExpr().getExpr()`
`61`		`- )`
	`57`	`+ any(EqualityOperation eqOp).getAnOperand() = sink.asExpr().getExpr()`
`62`	`58`	`}`
`63`	`59`	`}`
`64`	`60`