Skip to content

Commit 9534e56

Browse files
committed
Python: address review comments
1 parent 92a5b6f commit 9534e56

File tree

2 files changed

+3
-3
lines changed

2 files changed

+3
-3
lines changed
Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
11
---
22
category: feature
33
---
4-
* A Python MaD row may now contain a dotted path in the `type` column. Like in Ruby, a path to a class will refer to instances. This means that the summary `["foo", "Member[MyClass].Instance.Member[instance_method]", "Argument[0]", "ReturnValue", "value"]` can now be written `["foo.MS_Class", "Member[instance_method]", "Argument[0]", "ReturnValue", "value"]`. To refer to an actual class, one may add a `!` at the end of the path.
4+
* A Python Models as Data row may now contain a dotted path in the `type` column. Like in Ruby, a path to a class will refer to instances. This means that the summary `["foo", "Member[MyClass].Instance.Member[instance_method]", "Argument[0]", "ReturnValue", "value"]` can now be written `["foo.MS_Class", "Member[instance_method]", "Argument[0]", "ReturnValue", "value"]`. To refer to an actual class, one may add a `!` at the end of the path.

python/ql/lib/semmle/python/frameworks/data/internal/ApiGraphModelsSpecific.qll

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -68,7 +68,7 @@ private string getTypePathComponent(string typePath, int n) {
6868
result = typePath.splitAt(".", n)
6969
}
7070

71-
private int getNumTypePathomponents(string typePath) {
71+
private int getNumTypePathComponents(string typePath) {
7272
result = strictcount(int n | exists(getTypePathComponent(typePath, n)))
7373
}
7474

@@ -80,7 +80,7 @@ private API::Node getNodeFromTypePath(string typePath, int n) {
8080
}
8181

8282
private API::Node getNodeFromTypePath(string typePath) {
83-
result = getNodeFromTypePath(typePath, getNumTypePathomponents(typePath))
83+
result = getNodeFromTypePath(typePath, getNumTypePathComponents(typePath))
8484
}
8585

8686
/** Gets a Python-specific interpretation of the given `type`. */

0 commit comments

Comments
 (0)