Update java/ql/test/query-tests/security/CWE-611/DocumentBuilderTests.java

smowton · intrigus-lgtm · web-flow · commit 9540beeda933 · 2021-11-25T12:52:08.000Z
Co-authored-by: intrigus-lgtm &lt;60750685+intrigus-lgtm@users.noreply.github.com&gt;
diff --git a/java/ql/test/query-tests/security/CWE-611/DocumentBuilderTests.java b/java/ql/test/query-tests/security/CWE-611/DocumentBuilderTests.java
@@ -32,7 +32,7 @@ public void enableSecurityFeature2(Socket sock) throws Exception {
     DocumentBuilderFactory factory = DocumentBuilderFactory.newInstance();
     factory.setFeature("http://javax.xml.XMLConstants/feature/secure-processing", true);
     DocumentBuilder builder = factory.newDocumentBuilder();
-    builder.parse(sock.getInputStream()); //safe -- secure-processing by itself is insufficient
+    builder.parse(sock.getInputStream()); //unsafe -- secure-processing by itself is insufficient
   }
 
   public void enableDTD(Socket sock) throws Exception {

Original file line number	Diff line number	Diff line change
`@@ -32,7 +32,7 @@ public void enableSecurityFeature2(Socket sock) throws Exception {`
`32`	`32`	`DocumentBuilderFactory factory = DocumentBuilderFactory.newInstance();`
`33`	`33`	`factory.setFeature("http://javax.xml.XMLConstants/feature/secure-processing", true);`
`34`	`34`	`DocumentBuilder builder = factory.newDocumentBuilder();`
`35`		`- builder.parse(sock.getInputStream()); //safe -- secure-processing by itself is insufficient`
	`35`	`+ builder.parse(sock.getInputStream()); //unsafe -- secure-processing by itself is insufficient`
`36`	`36`	`}`
`37`	`37`
`38`	`38`	`public void enableDTD(Socket sock) throws Exception {`