C#: Fix .ToList() being called on null

mbg · mbg · commit 95605935fa03 · 2025-03-14T14:02:38.000Z
diff --git a/csharp/extractor/Semmle.Extraction.CSharp.DependencyFetching/NugetPackageRestorer.cs b/csharp/extractor/Semmle.Extraction.CSharp.DependencyFetching/NugetPackageRestorer.cs
@@ -292,7 +292,7 @@ private void RestoreProjects(IEnumerable<string> projects, HashSet<string>? conf
                 foreach (var project in projectGroup)
                 {
                     logger.LogInfo($"Restoring project {project}...");
-                    var res = dotnet.Restore(new(project, PackageDirectory.DirInfo.FullName, ForceDotnetRefAssemblyFetching: true, sources.ToList(), TargetWindows: isWindows));
+                    var res = dotnet.Restore(new(project, PackageDirectory.DirInfo.FullName, ForceDotnetRefAssemblyFetching: true, sources?.ToList(), TargetWindows: isWindows));
                     assets.AddDependenciesRange(res.AssetsFilePaths);
                     lock (sync)
                     {

Original file line number	Diff line number	Diff line change
`@@ -292,7 +292,7 @@ private void RestoreProjects(IEnumerable<string> projects, HashSet<string>? conf`
`292`	`292`	`foreach (var project in projectGroup)`
`293`	`293`	`{`
`294`	`294`	`logger.LogInfo($"Restoring project {project}...");`
`295`		`- var res = dotnet.Restore(new(project, PackageDirectory.DirInfo.FullName, ForceDotnetRefAssemblyFetching: true, sources.ToList(), TargetWindows: isWindows));`
	`295`	`+ var res = dotnet.Restore(new(project, PackageDirectory.DirInfo.FullName, ForceDotnetRefAssemblyFetching: true, sources?.ToList(), TargetWindows: isWindows));`
`296`	`296`	`assets.AddDependenciesRange(res.AssetsFilePaths);`
`297`	`297`	`lock (sync)`
`298`	`298`	`{`