C#: Mass enable quality queries and update tags.

Author: michaelnebel

csharp/ql/src/API Abuse/CallToGCCollect.ql

@@ -5,9 +5,9 @@
  * @problem.severity warning
  * @precision very-high
  * @id cs/call-to-gc
- * @tags efficiency
- *       maintainability
- *       quality
+ * @tags quality
+ *       reliability
+ *       performance
  */
 
 import csharp

csharp/ql/src/API Abuse/CallToObsoleteMethod.ql

@@ -6,8 +6,9 @@
  * @problem.severity warning
  * @precision very-high
  * @id cs/call-to-obsolete-method
- * @tags changeability
+ * @tags quality
  *       maintainability
+ *       changeability
  *       external/cwe/cwe-477
  */
 

csharp/ql/src/API Abuse/ClassImplementsICloneable.ql

@@ -6,7 +6,7 @@
  * @problem.severity recommendation
  * @precision very-high
  * @id cs/class-implements-icloneable
- * @tags reliability
+ * @tags quality
  *       maintainability
  */
 

csharp/ql/src/API Abuse/FormatInvalid.ql

@@ -6,9 +6,9 @@
  * @problem.severity error
  * @precision high
  * @id cs/invalid-string-formatting
- * @tags reliability
- *       maintainability
- *       quality
+ * @tags quality
+ *       reliability
+ *       correctness
  */
 
 import csharp

csharp/ql/src/API Abuse/NoDisposeCallOnLocalIDisposable.ql

@@ -6,9 +6,10 @@
  * @problem.severity warning
  * @precision high
  * @id cs/local-not-disposed
- * @tags efficiency
- *       maintainability
- *       quality
+ * @tags quality
+ *       reliability
+ *       correctness
+ *       efficiency
  *       external/cwe/cwe-404
  *       external/cwe/cwe-459
  *       external/cwe/cwe-460

csharp/ql/src/API Abuse/NullArgumentToEquals.ql

@@ -6,7 +6,8 @@
  * @problem.severity warning
  * @precision high
  * @id cs/null-argument-to-equals
- * @tags reliability
+ * @tags quality
+ *       reliability
  *       correctness
  */
 

csharp/ql/src/ASP/BlockCodeResponseWrite.ql

@@ -5,7 +5,9 @@
  * @problem.severity recommendation
  * @precision high
  * @id cs/asp/response-write
- * @tags maintainability
+ * @tags quality
+ *       maintainability
+ *       readability
  *       frameworks/asp.net
  */
 

csharp/ql/src/Architecture/Refactoring Opportunities/InappropriateIntimacy.ql

@@ -6,7 +6,9 @@
  * @problem.severity recommendation
  * @precision high
  * @id cs/coupled-types
- * @tags maintainability
+ * @tags quality
+ *       maintainability
+ *       complexity
  *       modularity
  */
 

csharp/ql/src/Bad Practices/CallsUnmanagedCode.ql

@@ -5,8 +5,9 @@
  * @problem.severity recommendation
  * @precision high
  * @id cs/call-to-unmanaged-code
- * @tags reliability
- *       maintainability
+ * @tags quality
+ *       reliability
+ *       correctness
  */
 
 import csharp

csharp/ql/src/Bad Practices/CatchOfNullReferenceException.ql

@@ -5,8 +5,10 @@
  * @problem.severity warning
  * @precision very-high
  * @id cs/catch-nullreferenceexception
- * @tags reliability
+ * @tags quality
+ *       reliability
  *       correctness
+ *       error-handling
  *       external/cwe/cwe-395
  */