Skip to content

Commit 9753276

Browse files
egregius313egregius313
committed
Remove commented-out code
1 parent 5156420 commit 9753276

File tree

7 files changed

+162
-163
lines changed

7 files changed

+162
-163
lines changed

‎csharp/ql/test/library-tests/dataflow/threat-models/Test.cs

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,6 @@ public class Test
77
{
88
private TestSources Sources = new TestSources();
99

10-
//private ILogger Logger => throw null;
1110
private SqlConnection Connection => throw null;
1211

1312
private string BytesToString(byte[] bytes)

‎csharp/ql/test/library-tests/dataflow/threat-models/threat-models-flowtest1.expected

Lines changed: 19 additions & 19 deletions
Original file line numberDiff line numberDiff line change
@@ -1,23 +1,23 @@
11
edges
2-
| Test.cs:13:45:13:49 | bytes : Byte[] [element] : Object | Test.cs:16:56:16:60 | access to parameter bytes : Byte[] [element] : Object |
3-
| Test.cs:16:56:16:60 | access to parameter bytes : Byte[] [element] : Object | Test.cs:16:20:16:61 | call to method GetString : String |
4-
| Test.cs:24:42:24:59 | call to method GetStream : NetworkStream | Test.cs:26:29:26:34 | access to local variable stream : NetworkStream |
5-
| Test.cs:26:29:26:34 | access to local variable stream : NetworkStream | Test.cs:26:41:26:46 | [post] access to local variable buffer : Byte[] [element] : Object |
6-
| Test.cs:26:41:26:46 | [post] access to local variable buffer : Byte[] [element] : Object | Test.cs:29:99:29:104 | access to local variable buffer : Byte[] [element] : Object |
7-
| Test.cs:29:85:29:105 | call to method BytesToString : String | Test.cs:29:42:29:111 | ... + ... |
8-
| Test.cs:29:99:29:104 | access to local variable buffer : Byte[] [element] : Object | Test.cs:13:45:13:49 | bytes : Byte[] [element] : Object |
9-
| Test.cs:29:99:29:104 | access to local variable buffer : Byte[] [element] : Object | Test.cs:29:85:29:105 | call to method BytesToString : String |
2+
| Test.cs:12:45:12:49 | bytes : Byte[] [element] : Object | Test.cs:15:56:15:60 | access to parameter bytes : Byte[] [element] : Object |
3+
| Test.cs:15:56:15:60 | access to parameter bytes : Byte[] [element] : Object | Test.cs:15:20:15:61 | call to method GetString : String |
4+
| Test.cs:23:42:23:59 | call to method GetStream : NetworkStream | Test.cs:25:29:25:34 | access to local variable stream : NetworkStream |
5+
| Test.cs:25:29:25:34 | access to local variable stream : NetworkStream | Test.cs:25:41:25:46 | [post] access to local variable buffer : Byte[] [element] : Object |
6+
| Test.cs:25:41:25:46 | [post] access to local variable buffer : Byte[] [element] : Object | Test.cs:28:99:28:104 | access to local variable buffer : Byte[] [element] : Object |
7+
| Test.cs:28:85:28:105 | call to method BytesToString : String | Test.cs:28:42:28:111 | ... + ... |
8+
| Test.cs:28:99:28:104 | access to local variable buffer : Byte[] [element] : Object | Test.cs:12:45:12:49 | bytes : Byte[] [element] : Object |
9+
| Test.cs:28:99:28:104 | access to local variable buffer : Byte[] [element] : Object | Test.cs:28:85:28:105 | call to method BytesToString : String |
1010
nodes
11-
| Test.cs:13:45:13:49 | bytes : Byte[] [element] : Object | semmle.label | bytes : Byte[] [element] : Object |
12-
| Test.cs:16:20:16:61 | call to method GetString : String | semmle.label | call to method GetString : String |
13-
| Test.cs:16:56:16:60 | access to parameter bytes : Byte[] [element] : Object | semmle.label | access to parameter bytes : Byte[] [element] : Object |
14-
| Test.cs:24:42:24:59 | call to method GetStream : NetworkStream | semmle.label | call to method GetStream : NetworkStream |
15-
| Test.cs:26:29:26:34 | access to local variable stream : NetworkStream | semmle.label | access to local variable stream : NetworkStream |
16-
| Test.cs:26:41:26:46 | [post] access to local variable buffer : Byte[] [element] : Object | semmle.label | [post] access to local variable buffer : Byte[] [element] : Object |
17-
| Test.cs:29:42:29:111 | ... + ... | semmle.label | ... + ... |
18-
| Test.cs:29:85:29:105 | call to method BytesToString : String | semmle.label | call to method BytesToString : String |
19-
| Test.cs:29:99:29:104 | access to local variable buffer : Byte[] [element] : Object | semmle.label | access to local variable buffer : Byte[] [element] : Object |
11+
| Test.cs:12:45:12:49 | bytes : Byte[] [element] : Object | semmle.label | bytes : Byte[] [element] : Object |
12+
| Test.cs:15:20:15:61 | call to method GetString : String | semmle.label | call to method GetString : String |
13+
| Test.cs:15:56:15:60 | access to parameter bytes : Byte[] [element] : Object | semmle.label | access to parameter bytes : Byte[] [element] : Object |
14+
| Test.cs:23:42:23:59 | call to method GetStream : NetworkStream | semmle.label | call to method GetStream : NetworkStream |
15+
| Test.cs:25:29:25:34 | access to local variable stream : NetworkStream | semmle.label | access to local variable stream : NetworkStream |
16+
| Test.cs:25:41:25:46 | [post] access to local variable buffer : Byte[] [element] : Object | semmle.label | [post] access to local variable buffer : Byte[] [element] : Object |
17+
| Test.cs:28:42:28:111 | ... + ... | semmle.label | ... + ... |
18+
| Test.cs:28:85:28:105 | call to method BytesToString : String | semmle.label | call to method BytesToString : String |
19+
| Test.cs:28:99:28:104 | access to local variable buffer : Byte[] [element] : Object | semmle.label | access to local variable buffer : Byte[] [element] : Object |
2020
subpaths
21-
| Test.cs:29:99:29:104 | access to local variable buffer : Byte[] [element] : Object | Test.cs:13:45:13:49 | bytes : Byte[] [element] : Object | Test.cs:16:20:16:61 | call to method GetString : String | Test.cs:29:85:29:105 | call to method BytesToString : String |
21+
| Test.cs:28:99:28:104 | access to local variable buffer : Byte[] [element] : Object | Test.cs:12:45:12:49 | bytes : Byte[] [element] : Object | Test.cs:15:20:15:61 | call to method GetString : String | Test.cs:28:85:28:105 | call to method BytesToString : String |
2222
#select
23-
| Test.cs:24:42:24:59 | call to method GetStream : NetworkStream | Test.cs:29:42:29:111 | ... + ... |
23+
| Test.cs:23:42:23:59 | call to method GetStream : NetworkStream | Test.cs:28:42:28:111 | ... + ... |

‎csharp/ql/test/library-tests/dataflow/threat-models/threat-models-flowtest2.expected

Lines changed: 23 additions & 23 deletions
Original file line numberDiff line numberDiff line change
@@ -1,27 +1,27 @@
11
edges
2-
| Test.cs:13:45:13:49 | bytes : Byte[] [element] : Object | Test.cs:16:56:16:60 | access to parameter bytes : Byte[] [element] : Object |
3-
| Test.cs:16:56:16:60 | access to parameter bytes : Byte[] [element] : Object | Test.cs:16:20:16:61 | call to method GetString : String |
4-
| Test.cs:24:42:24:59 | call to method GetStream : NetworkStream | Test.cs:26:29:26:34 | access to local variable stream : NetworkStream |
5-
| Test.cs:26:29:26:34 | access to local variable stream : NetworkStream | Test.cs:26:41:26:46 | [post] access to local variable buffer : Byte[] [element] : Object |
6-
| Test.cs:26:41:26:46 | [post] access to local variable buffer : Byte[] [element] : Object | Test.cs:29:99:29:104 | access to local variable buffer : Byte[] [element] : Object |
7-
| Test.cs:29:85:29:105 | call to method BytesToString : String | Test.cs:29:42:29:111 | ... + ... |
8-
| Test.cs:29:99:29:104 | access to local variable buffer : Byte[] [element] : Object | Test.cs:13:45:13:49 | bytes : Byte[] [element] : Object |
9-
| Test.cs:29:99:29:104 | access to local variable buffer : Byte[] [element] : Object | Test.cs:29:85:29:105 | call to method BytesToString : String |
10-
| Test.cs:35:29:35:69 | call to method ExecuteQuery : String | Test.cs:38:42:38:96 | ... + ... |
2+
| Test.cs:12:45:12:49 | bytes : Byte[] [element] : Object | Test.cs:15:56:15:60 | access to parameter bytes : Byte[] [element] : Object |
3+
| Test.cs:15:56:15:60 | access to parameter bytes : Byte[] [element] : Object | Test.cs:15:20:15:61 | call to method GetString : String |
4+
| Test.cs:23:42:23:59 | call to method GetStream : NetworkStream | Test.cs:25:29:25:34 | access to local variable stream : NetworkStream |
5+
| Test.cs:25:29:25:34 | access to local variable stream : NetworkStream | Test.cs:25:41:25:46 | [post] access to local variable buffer : Byte[] [element] : Object |
6+
| Test.cs:25:41:25:46 | [post] access to local variable buffer : Byte[] [element] : Object | Test.cs:28:99:28:104 | access to local variable buffer : Byte[] [element] : Object |
7+
| Test.cs:28:85:28:105 | call to method BytesToString : String | Test.cs:28:42:28:111 | ... + ... |
8+
| Test.cs:28:99:28:104 | access to local variable buffer : Byte[] [element] : Object | Test.cs:12:45:12:49 | bytes : Byte[] [element] : Object |
9+
| Test.cs:28:99:28:104 | access to local variable buffer : Byte[] [element] : Object | Test.cs:28:85:28:105 | call to method BytesToString : String |
10+
| Test.cs:34:29:34:69 | call to method ExecuteQuery : String | Test.cs:37:42:37:96 | ... + ... |
1111
nodes
12-
| Test.cs:13:45:13:49 | bytes : Byte[] [element] : Object | semmle.label | bytes : Byte[] [element] : Object |
13-
| Test.cs:16:20:16:61 | call to method GetString : String | semmle.label | call to method GetString : String |
14-
| Test.cs:16:56:16:60 | access to parameter bytes : Byte[] [element] : Object | semmle.label | access to parameter bytes : Byte[] [element] : Object |
15-
| Test.cs:24:42:24:59 | call to method GetStream : NetworkStream | semmle.label | call to method GetStream : NetworkStream |
16-
| Test.cs:26:29:26:34 | access to local variable stream : NetworkStream | semmle.label | access to local variable stream : NetworkStream |
17-
| Test.cs:26:41:26:46 | [post] access to local variable buffer : Byte[] [element] : Object | semmle.label | [post] access to local variable buffer : Byte[] [element] : Object |
18-
| Test.cs:29:42:29:111 | ... + ... | semmle.label | ... + ... |
19-
| Test.cs:29:85:29:105 | call to method BytesToString : String | semmle.label | call to method BytesToString : String |
20-
| Test.cs:29:99:29:104 | access to local variable buffer : Byte[] [element] : Object | semmle.label | access to local variable buffer : Byte[] [element] : Object |
21-
| Test.cs:35:29:35:69 | call to method ExecuteQuery : String | semmle.label | call to method ExecuteQuery : String |
22-
| Test.cs:38:42:38:96 | ... + ... | semmle.label | ... + ... |
12+
| Test.cs:12:45:12:49 | bytes : Byte[] [element] : Object | semmle.label | bytes : Byte[] [element] : Object |
13+
| Test.cs:15:20:15:61 | call to method GetString : String | semmle.label | call to method GetString : String |
14+
| Test.cs:15:56:15:60 | access to parameter bytes : Byte[] [element] : Object | semmle.label | access to parameter bytes : Byte[] [element] : Object |
15+
| Test.cs:23:42:23:59 | call to method GetStream : NetworkStream | semmle.label | call to method GetStream : NetworkStream |
16+
| Test.cs:25:29:25:34 | access to local variable stream : NetworkStream | semmle.label | access to local variable stream : NetworkStream |
17+
| Test.cs:25:41:25:46 | [post] access to local variable buffer : Byte[] [element] : Object | semmle.label | [post] access to local variable buffer : Byte[] [element] : Object |
18+
| Test.cs:28:42:28:111 | ... + ... | semmle.label | ... + ... |
19+
| Test.cs:28:85:28:105 | call to method BytesToString : String | semmle.label | call to method BytesToString : String |
20+
| Test.cs:28:99:28:104 | access to local variable buffer : Byte[] [element] : Object | semmle.label | access to local variable buffer : Byte[] [element] : Object |
21+
| Test.cs:34:29:34:69 | call to method ExecuteQuery : String | semmle.label | call to method ExecuteQuery : String |
22+
| Test.cs:37:42:37:96 | ... + ... | semmle.label | ... + ... |
2323
subpaths
24-
| Test.cs:29:99:29:104 | access to local variable buffer : Byte[] [element] : Object | Test.cs:13:45:13:49 | bytes : Byte[] [element] : Object | Test.cs:16:20:16:61 | call to method GetString : String | Test.cs:29:85:29:105 | call to method BytesToString : String |
24+
| Test.cs:28:99:28:104 | access to local variable buffer : Byte[] [element] : Object | Test.cs:12:45:12:49 | bytes : Byte[] [element] : Object | Test.cs:15:20:15:61 | call to method GetString : String | Test.cs:28:85:28:105 | call to method BytesToString : String |
2525
#select
26-
| Test.cs:24:42:24:59 | call to method GetStream : NetworkStream | Test.cs:29:42:29:111 | ... + ... |
27-
| Test.cs:35:29:35:69 | call to method ExecuteQuery : String | Test.cs:38:42:38:96 | ... + ... |
26+
| Test.cs:23:42:23:59 | call to method GetStream : NetworkStream | Test.cs:28:42:28:111 | ... + ... |
27+
| Test.cs:34:29:34:69 | call to method ExecuteQuery : String | Test.cs:37:42:37:96 | ... + ... |

‎csharp/ql/test/library-tests/dataflow/threat-models/threat-models-flowtest3.expected

Lines changed: 31 additions & 31 deletions
Original file line numberDiff line numberDiff line change
@@ -1,35 +1,35 @@
11
edges
2-
| Test.cs:13:45:13:49 | bytes : Byte[] [element] : Object | Test.cs:16:56:16:60 | access to parameter bytes : Byte[] [element] : Object |
3-
| Test.cs:16:56:16:60 | access to parameter bytes : Byte[] [element] : Object | Test.cs:16:20:16:61 | call to method GetString : String |
4-
| Test.cs:24:42:24:59 | call to method GetStream : NetworkStream | Test.cs:26:29:26:34 | access to local variable stream : NetworkStream |
5-
| Test.cs:26:29:26:34 | access to local variable stream : NetworkStream | Test.cs:26:41:26:46 | [post] access to local variable buffer : Byte[] [element] : Object |
6-
| Test.cs:26:41:26:46 | [post] access to local variable buffer : Byte[] [element] : Object | Test.cs:29:99:29:104 | access to local variable buffer : Byte[] [element] : Object |
7-
| Test.cs:29:85:29:105 | call to method BytesToString : String | Test.cs:29:42:29:111 | ... + ... |
8-
| Test.cs:29:99:29:104 | access to local variable buffer : Byte[] [element] : Object | Test.cs:13:45:13:49 | bytes : Byte[] [element] : Object |
9-
| Test.cs:29:99:29:104 | access to local variable buffer : Byte[] [element] : Object | Test.cs:29:85:29:105 | call to method BytesToString : String |
10-
| Test.cs:35:29:35:69 | call to method ExecuteQuery : String | Test.cs:38:42:38:96 | ... + ... |
11-
| Test.cs:44:29:44:50 | call to method ReadEnv : String | Test.cs:47:42:47:96 | ... + ... |
12-
| Test.cs:63:29:63:48 | call to method GetCliArg : String | Test.cs:66:42:66:96 | ... + ... |
2+
| Test.cs:12:45:12:49 | bytes : Byte[] [element] : Object | Test.cs:15:56:15:60 | access to parameter bytes : Byte[] [element] : Object |
3+
| Test.cs:15:56:15:60 | access to parameter bytes : Byte[] [element] : Object | Test.cs:15:20:15:61 | call to method GetString : String |
4+
| Test.cs:23:42:23:59 | call to method GetStream : NetworkStream | Test.cs:25:29:25:34 | access to local variable stream : NetworkStream |
5+
| Test.cs:25:29:25:34 | access to local variable stream : NetworkStream | Test.cs:25:41:25:46 | [post] access to local variable buffer : Byte[] [element] : Object |
6+
| Test.cs:25:41:25:46 | [post] access to local variable buffer : Byte[] [element] : Object | Test.cs:28:99:28:104 | access to local variable buffer : Byte[] [element] : Object |
7+
| Test.cs:28:85:28:105 | call to method BytesToString : String | Test.cs:28:42:28:111 | ... + ... |
8+
| Test.cs:28:99:28:104 | access to local variable buffer : Byte[] [element] : Object | Test.cs:12:45:12:49 | bytes : Byte[] [element] : Object |
9+
| Test.cs:28:99:28:104 | access to local variable buffer : Byte[] [element] : Object | Test.cs:28:85:28:105 | call to method BytesToString : String |
10+
| Test.cs:34:29:34:69 | call to method ExecuteQuery : String | Test.cs:37:42:37:96 | ... + ... |
11+
| Test.cs:43:29:43:50 | call to method ReadEnv : String | Test.cs:46:42:46:96 | ... + ... |
12+
| Test.cs:62:29:62:48 | call to method GetCliArg : String | Test.cs:65:42:65:96 | ... + ... |
1313
nodes
14-
| Test.cs:13:45:13:49 | bytes : Byte[] [element] : Object | semmle.label | bytes : Byte[] [element] : Object |
15-
| Test.cs:16:20:16:61 | call to method GetString : String | semmle.label | call to method GetString : String |
16-
| Test.cs:16:56:16:60 | access to parameter bytes : Byte[] [element] : Object | semmle.label | access to parameter bytes : Byte[] [element] : Object |
17-
| Test.cs:24:42:24:59 | call to method GetStream : NetworkStream | semmle.label | call to method GetStream : NetworkStream |
18-
| Test.cs:26:29:26:34 | access to local variable stream : NetworkStream | semmle.label | access to local variable stream : NetworkStream |
19-
| Test.cs:26:41:26:46 | [post] access to local variable buffer : Byte[] [element] : Object | semmle.label | [post] access to local variable buffer : Byte[] [element] : Object |
20-
| Test.cs:29:42:29:111 | ... + ... | semmle.label | ... + ... |
21-
| Test.cs:29:85:29:105 | call to method BytesToString : String | semmle.label | call to method BytesToString : String |
22-
| Test.cs:29:99:29:104 | access to local variable buffer : Byte[] [element] : Object | semmle.label | access to local variable buffer : Byte[] [element] : Object |
23-
| Test.cs:35:29:35:69 | call to method ExecuteQuery : String | semmle.label | call to method ExecuteQuery : String |
24-
| Test.cs:38:42:38:96 | ... + ... | semmle.label | ... + ... |
25-
| Test.cs:44:29:44:50 | call to method ReadEnv : String | semmle.label | call to method ReadEnv : String |
26-
| Test.cs:47:42:47:96 | ... + ... | semmle.label | ... + ... |
27-
| Test.cs:63:29:63:48 | call to method GetCliArg : String | semmle.label | call to method GetCliArg : String |
28-
| Test.cs:66:42:66:96 | ... + ... | semmle.label | ... + ... |
14+
| Test.cs:12:45:12:49 | bytes : Byte[] [element] : Object | semmle.label | bytes : Byte[] [element] : Object |
15+
| Test.cs:15:20:15:61 | call to method GetString : String | semmle.label | call to method GetString : String |
16+
| Test.cs:15:56:15:60 | access to parameter bytes : Byte[] [element] : Object | semmle.label | access to parameter bytes : Byte[] [element] : Object |
17+
| Test.cs:23:42:23:59 | call to method GetStream : NetworkStream | semmle.label | call to method GetStream : NetworkStream |
18+
| Test.cs:25:29:25:34 | access to local variable stream : NetworkStream | semmle.label | access to local variable stream : NetworkStream |
19+
| Test.cs:25:41:25:46 | [post] access to local variable buffer : Byte[] [element] : Object | semmle.label | [post] access to local variable buffer : Byte[] [element] : Object |
20+
| Test.cs:28:42:28:111 | ... + ... | semmle.label | ... + ... |
21+
| Test.cs:28:85:28:105 | call to method BytesToString : String | semmle.label | call to method BytesToString : String |
22+
| Test.cs:28:99:28:104 | access to local variable buffer : Byte[] [element] : Object | semmle.label | access to local variable buffer : Byte[] [element] : Object |
23+
| Test.cs:34:29:34:69 | call to method ExecuteQuery : String | semmle.label | call to method ExecuteQuery : String |
24+
| Test.cs:37:42:37:96 | ... + ... | semmle.label | ... + ... |
25+
| Test.cs:43:29:43:50 | call to method ReadEnv : String | semmle.label | call to method ReadEnv : String |
26+
| Test.cs:46:42:46:96 | ... + ... | semmle.label | ... + ... |
27+
| Test.cs:62:29:62:48 | call to method GetCliArg : String | semmle.label | call to method GetCliArg : String |
28+
| Test.cs:65:42:65:96 | ... + ... | semmle.label | ... + ... |
2929
subpaths
30-
| Test.cs:29:99:29:104 | access to local variable buffer : Byte[] [element] : Object | Test.cs:13:45:13:49 | bytes : Byte[] [element] : Object | Test.cs:16:20:16:61 | call to method GetString : String | Test.cs:29:85:29:105 | call to method BytesToString : String |
30+
| Test.cs:28:99:28:104 | access to local variable buffer : Byte[] [element] : Object | Test.cs:12:45:12:49 | bytes : Byte[] [element] : Object | Test.cs:15:20:15:61 | call to method GetString : String | Test.cs:28:85:28:105 | call to method BytesToString : String |
3131
#select
32-
| Test.cs:24:42:24:59 | call to method GetStream : NetworkStream | Test.cs:29:42:29:111 | ... + ... |
33-
| Test.cs:35:29:35:69 | call to method ExecuteQuery : String | Test.cs:38:42:38:96 | ... + ... |
34-
| Test.cs:44:29:44:50 | call to method ReadEnv : String | Test.cs:47:42:47:96 | ... + ... |
35-
| Test.cs:63:29:63:48 | call to method GetCliArg : String | Test.cs:66:42:66:96 | ... + ... |
32+
| Test.cs:23:42:23:59 | call to method GetStream : NetworkStream | Test.cs:28:42:28:111 | ... + ... |
33+
| Test.cs:34:29:34:69 | call to method ExecuteQuery : String | Test.cs:37:42:37:96 | ... + ... |
34+
| Test.cs:43:29:43:50 | call to method ReadEnv : String | Test.cs:46:42:46:96 | ... + ... |
35+
| Test.cs:62:29:62:48 | call to method GetCliArg : String | Test.cs:65:42:65:96 | ... + ... |

0 commit comments

Comments
 (0)