Skip to content

Commit 976ca48

Browse files
Review suggestions - rename sink class and add barrier out
1 parent c2d771b commit 976ca48

File tree

2 files changed

+5
-6
lines changed

2 files changed

+5
-6
lines changed

ruby/ql/lib/codeql/ruby/frameworks/ActiveRecord.qll

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -806,8 +806,8 @@ private module MassAssignmentSinks {
806806
}
807807

808808
/** A call to a method that sets attributes of an database record using a hash. */
809-
private class MassAssignmentCall extends MassAssignment::Sink {
810-
MassAssignmentCall() {
809+
private class MassAssignmentSink extends MassAssignment::Sink {
810+
MassAssignmentSink() {
811811
exists(DataFlow::CallNode call, string name | massAssignmentCall(call, name) |
812812
name =
813813
[

ruby/ql/lib/codeql/ruby/security/MassAssignmentQuery.qll

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -43,10 +43,9 @@ private module Config implements DataFlow::StateConfigSig {
4343
state instanceof FlowState::Permitted
4444
}
4545

46-
predicate isBarrierIn(DataFlow::Node node, FlowState state) {
47-
node instanceof MassAssignment::Source and
48-
state instanceof FlowState::Unpermitted
49-
}
46+
predicate isBarrierIn(DataFlow::Node node, FlowState state) { isSource(node, state) }
47+
48+
predicate isBarrierOut(DataFlow::Node node, FlowState state) { isSink(node, state) }
5049

5150
predicate isBarrier(DataFlow::Node node) { node instanceof MassAssignment::Sanitizer }
5251

0 commit comments

Comments
 (0)