Skip to content

Commit 989402d

Browse files
committed
JS: Remove some dependencies on type extraction
1 parent 6ac35f1 commit 989402d

File tree

2 files changed

+3
-9
lines changed

2 files changed

+3
-9
lines changed

javascript/ql/lib/semmle/javascript/ApiGraphs.qll

Lines changed: 2 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -751,18 +751,14 @@ module API {
751751
MkModuleImport(string m) {
752752
imports(_, m)
753753
or
754-
any(TypeAnnotation n).hasQualifiedName(m, _)
755-
or
756-
any(Type t).hasUnderlyingType(m, _)
754+
any(TypeAnnotation n).hasUnderlyingType(m, _)
757755
} or
758756
MkClassInstance(DataFlow::ClassNode cls) { needsDefNode(cls) } or
759757
MkDef(DataFlow::Node nd) { rhs(_, _, nd) } or
760758
MkUse(DataFlow::Node nd) { use(_, _, nd) } or
761759
/** A use of a TypeScript type. */
762760
MkTypeUse(string moduleName, string exportName) {
763-
any(TypeAnnotation n).hasQualifiedName(moduleName, exportName)
764-
or
765-
any(Type t).hasUnderlyingType(moduleName, exportName)
761+
any(TypeAnnotation n).hasUnderlyingType(moduleName, exportName)
766762
} or
767763
MkSyntheticCallbackArg(DataFlow::Node src, int bound, DataFlow::InvokeNode nd) {
768764
trackUseNode(src, true, bound, "").flowsTo(nd.getCalleeNode())

javascript/ql/lib/semmle/javascript/frameworks/data/internal/ApiGraphModelsSpecific.qll

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -60,9 +60,7 @@ predicate isPackageUsed(string package) {
6060
or
6161
package = any(JS::Import imp).getImportedPathString()
6262
or
63-
any(JS::TypeName t).hasQualifiedName(package, _)
64-
or
65-
any(JS::TypeAnnotation t).hasQualifiedName(package, _)
63+
any(JS::TypeAnnotation t).hasUnderlyingType(package, _)
6664
or
6765
exists(JS::PackageJson json | json.getPackageName() = package)
6866
}

0 commit comments

Comments
 (0)