Skip to content

Commit 9c29451

Browse files
erik-kroghasgerf
andauthored
Apply suggestions from code review
Co-authored-by: Asger F <[email protected]>
1 parent 2d6e3a5 commit 9c29451

File tree

4 files changed

+4
-4
lines changed

4 files changed

+4
-4
lines changed

javascript/ql/src/Security/CWE-078/UnsafeShellCommandConstruction.qhelp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@
88
Dynamically constructing a shell command with inputs from exported
99
functions, may inadvertently change the meaning of the shell command.
1010

11-
Clients using the exported function may use inputs that contains
11+
Clients using the exported function may use inputs containing
1212
characters that the shell interprets in a special way, for instance
1313
quotes and spaces.
1414

javascript/ql/src/semmle/javascript/dataflow/TaintTracking.qll

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -779,7 +779,7 @@ module TaintTracking {
779779
class AdHocWhitelistCheckSanitizer extends SanitizerGuardNode, DataFlow::CallNode {
780780
AdHocWhitelistCheckSanitizer() {
781781
getCalleeName()
782-
.regexpMatch("(?i).*((?<!un)safe|whitelist|valid|allow|(?<!un)auth(?!or\\b)).*") and
782+
.regexpMatch("(?i).*((?<!un)safe|whitelist|(?<!in)valid|allow|(?<!un)auth(?!or\\b)).*") and
783783
getNumArgument() = 1
784784
}
785785

javascript/ql/src/semmle/javascript/security/dataflow/UnsafeShellCommandConstruction.qll

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@ module UnsafeShellCommandConstruction {
1919
* A taint-tracking configuration for reasoning about shell command constructed from library input vulnerabilities.
2020
*/
2121
class Configuration extends TaintTracking::Configuration {
22-
Configuration() { this = "UnsafeLibaryCommandInjection" }
22+
Configuration() { this = "UnsafeShellCommandConstruction" }
2323

2424
override predicate isSource(DataFlow::Node source) { source instanceof Source }
2525

javascript/ql/src/semmle/javascript/security/dataflow/UnsafeShellCommandConstructionCustomizations.qll

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -34,7 +34,7 @@ module UnsafeShellCommandConstruction {
3434

3535
/**
3636
* Gets the node that should be highlighted for this sink.
37-
* E.g. for a string concatenation, the sink is one of the leafs and the highlight is the concatenation root.
37+
* E.g. for a string concatenation, the sink is one of the leaves and the highlight is the concatenation root.
3838
*/
3939
abstract DataFlow::Node getHighLight();
4040
}

0 commit comments

Comments
 (0)