Skip to content

Commit 9c409f1

Browse files
committed
Apply cosmetic review feedback
1 parent 5548662 commit 9c409f1

File tree

2 files changed

+9
-8
lines changed

2 files changed

+9
-8
lines changed

go/ql/lib/semmle/go/dataflow/internal/DataFlowUtil.qll

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -54,7 +54,7 @@ abstract class FunctionModel extends Function {
5454
/**
5555
* A unit class for adding nodes that should implicitly read from all nested content.
5656
*
57-
* For example, this might be appopriate for the argument to a method that serializes a struct.
57+
* For example, this might be appropriate for the argument to a method that serializes a struct.
5858
*/
5959
class ImplicitFieldReadNode extends Unit {
6060
/**
@@ -276,7 +276,7 @@ class ContentSet instanceof TContentSet {
276276
Content getAReadContent() {
277277
this = TOneContent(result)
278278
or
279-
this = TAllContent() and result = any(Content c)
279+
this = TAllContent() and exists(result)
280280
}
281281

282282
/** Gets a textual representation of this content set. */

go/ql/lib/semmle/go/frameworks/stdlib/TextTemplate.qll

Lines changed: 7 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -69,15 +69,16 @@ module TextTemplate {
6969
}
7070

7171
private class ExecuteTemplateMethod extends Method {
72-
string name;
7372
int inputArg;
7473

7574
ExecuteTemplateMethod() {
76-
this.hasQualifiedName("text/template", "Template", name) and
77-
(
78-
name = "Execute" and inputArg = 1
79-
or
80-
name = "ExecuteTemplate" and inputArg = 2
75+
exists(string name |
76+
this.hasQualifiedName("text/template", "Template", name) and
77+
(
78+
name = "Execute" and inputArg = 1
79+
or
80+
name = "ExecuteTemplate" and inputArg = 2
81+
)
8182
)
8283
}
8384

0 commit comments

Comments
 (0)