Skip to content

Commit 9f08aca

Browse files
authored
Merge pull request #7170 from erik-krogh/qldocStyle
Ruby: use A/An/The to start qlDoc for classes
2 parents 344f7bc + 75586b0 commit 9f08aca

File tree

6 files changed

+12
-10
lines changed

6 files changed

+12
-10
lines changed

ruby/ql/lib/codeql/ruby/frameworks/ActiveStorage.qll

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@ private import codeql.ruby.Concepts
44
private import codeql.ruby.DataFlow
55
private import codeql.ruby.dataflow.FlowSummary
66

7-
/** Defines calls to `ActiveStorage::Filename#sanitized` as path sanitizers. */
7+
/** A call to `ActiveStorage::Filename#sanitized`, considered as a path sanitizer. */
88
class ActiveStorageFilenameSanitizedCall extends Path::PathSanitization::Range, DataFlow::CallNode {
99
ActiveStorageFilenameSanitizedCall() {
1010
this.getReceiver() =
@@ -13,7 +13,7 @@ class ActiveStorageFilenameSanitizedCall extends Path::PathSanitization::Range,
1313
}
1414
}
1515

16-
/** Taint summary for `ActiveStorage::Filename.new`. */
16+
/** The taint summary for `ActiveStorage::Filename.new`. */
1717
class ActiveStorageFilenameNewSummary extends SummarizedCallable {
1818
ActiveStorageFilenameNewSummary() { this = "ActiveStorage::Filename.new" }
1919

@@ -33,7 +33,7 @@ class ActiveStorageFilenameNewSummary extends SummarizedCallable {
3333
}
3434
}
3535

36-
/** Taint summary for `ActiveStorage::Filename#sanitized`. */
36+
/** The taint summary for `ActiveStorage::Filename#sanitized`. */
3737
class ActiveStorageFilenameSanitizedSummary extends SummarizedCallable {
3838
ActiveStorageFilenameSanitizedSummary() { this = "ActiveStorage::Filename#sanitized" }
3939

ruby/ql/lib/codeql/ruby/frameworks/Files.qll

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -254,7 +254,7 @@ module File {
254254
}
255255

256256
/**
257-
* Flow summary for several methods on the `File` class that propagate taint
257+
* A flow summary for several methods on the `File` class that propagate taint
258258
* from their first argument to the return value.
259259
*/
260260
class FilePathConversionSummary extends SummarizedCallable {
@@ -277,7 +277,7 @@ module File {
277277
}
278278

279279
/**
280-
* Flow summary for `File.join`, which propagates taint from every argument to
280+
* A flow summary for `File.join`, which propagates taint from every argument to
281281
* its return value.
282282
*/
283283
class FileJoinSummary extends SummarizedCallable {

ruby/ql/lib/codeql/ruby/frameworks/StandardLibrary.qll

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -71,7 +71,7 @@ string basicObjectInstanceMethodName() {
7171
}
7272

7373
/**
74-
* Instance methods on `BasicObject`, which are available to all classes.
74+
* An instance method on `BasicObject`, which is available to all classes.
7575
*/
7676
class BasicObjectInstanceMethodCall extends UnknownMethodCall {
7777
BasicObjectInstanceMethodCall() { this.getMethodName() = basicObjectInstanceMethodName() }
@@ -92,14 +92,14 @@ string objectInstanceMethodName() {
9292
}
9393

9494
/**
95-
* Instance methods on `Object`, which are available to all classes except `BasicObject`.
95+
* An instance method on `Object`, which is available to all classes except `BasicObject`.
9696
*/
9797
class ObjectInstanceMethodCall extends UnknownMethodCall {
9898
ObjectInstanceMethodCall() { this.getMethodName() = objectInstanceMethodName() }
9999
}
100100

101101
/**
102-
* Method calls which have no known target.
102+
* A `Method` call that has no known target.
103103
* These will typically be calls to methods inherited from a superclass.
104104
*/
105105
class UnknownMethodCall extends MethodCall {

ruby/ql/lib/codeql/ruby/security/UrlRedirectCustomizations.qll

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -85,6 +85,8 @@ module UrlRedirect {
8585
}
8686

8787
/**
88+
* A string interpolation, seen as a sanitizer for "URL redirection" vulnerabilities.
89+
*
8890
* String interpolation is considered safe, provided the string is prefixed by a non-tainted value.
8991
* In most cases this will prevent the tainted value from controlling e.g. the host of the URL.
9092
*

ruby/ql/src/ide-contextual-queries/printAst.ql

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@ private import codeql.ruby.printAst
1717
external string selectedSourceFile();
1818

1919
/**
20-
* Overrides the configuration to print only nodes in the selected source file.
20+
* A configuration that only prints nodes in the selected source file.
2121
*/
2222
class Cfg extends PrintAstConfiguration {
2323
override predicate shouldPrintNode(AstNode n) {

ruby/ql/src/queries/security/cwe-078/KernelOpen.ql

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,7 @@ import codeql.ruby.dataflow.RemoteFlowSources
2323
import DataFlow::PathGraph
2424

2525
/**
26-
* Method calls that have a suggested replacement.
26+
* A method call that has a suggested replacement.
2727
*/
2828
abstract class Replacement extends DataFlow::CallNode {
2929
abstract string getFrom();

0 commit comments

Comments
 (0)