Skip to content

Commit 9f59a35

Browse files
committed
Rust: Revert ipaddr and fingerprint terms (too many FPs).
1 parent 4778ef6 commit 9f59a35

File tree

2 files changed

+3
-3
lines changed

2 files changed

+3
-3
lines changed

rust/ql/lib/codeql/rust/security/internal/SensitiveDataHeuristics.qll

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -114,7 +114,7 @@ module HeuristicNames {
114114
// Relationships - work and family
115115
"employ(er|ee)|spouse|maiden.?name|" +
116116
// Device information
117-
"([_-]|\\b)ip.?addr|mac.?addr|finger.?print" +
117+
"mac.?addr" +
118118
// ---
119119
").*"
120120
}

rust/ql/test/library-tests/sensitivedata/test.rs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -164,8 +164,8 @@ impl DeviceInfo {
164164
sink(&self.api_key); // $ sensitive=password
165165
sink(&other.api_key); // $ sensitive=password
166166
sink(&self.deviceApiToken); // $ sensitive=password
167-
sink(&self.finger_print); // $ sensitive=private
168-
sink(&self.ip_address); // $ sensitive=private
167+
sink(&self.finger_print); // $ MISSING: sensitive=private
168+
sink(&self.ip_address); // $ MISSING: sensitive=private
169169
sink(self.macaddr12); // $ sensitive=private
170170
sink(&self.mac_addr); // $ sensitive=private
171171
sink(self.mac_addr.values); // $ sensitive=private

0 commit comments

Comments
 (0)