Go: IncorrectIntegerConversion

d10c · d10c · commit 9ffb3ff7e0bc · 2025-07-07T11:39:48.000+02:00
diff --git a/go/ql/lib/semmle/go/security/IncorrectIntegerConversionLib.qll b/go/ql/lib/semmle/go/security/IncorrectIntegerConversionLib.qll
@@ -441,8 +441,10 @@ private module ConversionWithoutBoundsCheckConfig implements DataFlow::StateConf
     DataFlow::simpleLocalFlowStep(node1, node2, _)
   }
 
-  predicate observeDiffInformedIncrementalMode() {
-    any() // TODO: Make sure that the location overrides match the query's select clause: Column 1 selects sink.getASuccessor (/Users/d10c/src/semmle-code/ql/go/ql/src/Security/CWE-681/IncorrectIntegerConversionQuery.ql@26:8:26:20)
+  predicate observeDiffInformedIncrementalMode() { any() }
+
+  Location getASelectedSinkLocation(DataFlow::Node sink) {
+    result = sink.getASuccessor().getLocation()
   }
 }
 

Original file line number	Diff line number	Diff line change
`@@ -441,8 +441,10 @@ private module ConversionWithoutBoundsCheckConfig implements DataFlow::StateConf`
`441`	`441`	`DataFlow::simpleLocalFlowStep(node1, node2, _)`
`442`	`442`	`}`
`443`	`443`
`444`		`- predicate observeDiffInformedIncrementalMode() {`
`445`		`- any() // TODO: Make sure that the location overrides match the query's select clause: Column 1 selects sink.getASuccessor (/Users/d10c/src/semmle-code/ql/go/ql/src/Security/CWE-681/IncorrectIntegerConversionQuery.ql@26:8:26:20)`
	`444`	`+ predicate observeDiffInformedIncrementalMode() { any() }`
	`445`	`+`
	`446`	`+ Location getASelectedSinkLocation(DataFlow::Node sink) {`
	`447`	`+ result = sink.getASuccessor().getLocation()`
`446`	`448`	`}`
`447`	`449`	`}`
`448`	`450`