Rewording

Author: atorralba

java/ql/src/Security/CWE/CWE-927/ImplicitPendingIntents.ql

@@ -1,13 +1,13 @@
 /**
- * @name Use of implicit Pending Intents
+ * @name Use of implicit PendingIntents
  * @description Implicit and mutable PendingIntents being sent to an unspecified third party
  *              component may provide access to internal components of the application or cause
  *              other unintended effects.
  * @kind path-problem
  * @problem.severity error
  * @security-severity 8.2
  * @precision high
- * @id java/android/pending-intents
+ * @id java/android/implicit-pendingintents
  * @tags security
  *       external/cwe/cwe-927
  */
@@ -20,5 +20,5 @@ import DataFlow::PathGraph
 from DataFlow::PathNode source, DataFlow::PathNode sink
 where any(ImplicitPendingIntentStartConf conf).hasFlowPath(source, sink)
 select sink.getNode(), source, sink,
-  "An implicit and mutable pending Intent is created $@ and sent to an unspecified third party.",
+  "An implicit and mutable PendingIntent is created $@ and sent to an unspecified third party.",
   source.getNode(), "here"

java/ql/src/change-notes/2021-09-30-android-implicit-pendingintents.md

@@ -1,7 +1,7 @@
 ---
 category: newQuery
 ---
-* A new query "Use of implicit Pending Intents" (`java/android/pending-intents`) has been added.
-This query finds implicit and mutable PendingIntents being sent to an unspecified third party component,
+* A new query "Use of implicit PendingIntents" (`java/android/pending-intents`) has been added.
+This query finds implicit and mutable `PendingIntents` being sent to an unspecified third party component,
 which can provide access to internal components of the application or cause other unintended
 effects.

java/ql/test/library-tests/frameworks/android/notification/Test.java

@@ -274,8 +274,7 @@ public void test() throws Exception {
 		}
 		{
 			// "android.app;Notification$Builder;true;setActions;;;ArrayElement of
-			// Argument[0];SyntheticField[android.app.Notification.action] of
-			// Argument[-1];taint"
+			// Argument[0];Argument[-1];taint"
 			Notification.Builder out = null;
 			Notification.Action[] in = (Notification.Action[]) new Notification.Action[] {
 					(Notification.Action) source()};