Rust: Accept test .expected changes.

Author: geoffw0

rust/ql/test/library-tests/dataflow/global/inline-flow.expected

@@ -1,5 +1,5 @@
 models
-| 1 | Summary: repo:https://github.com/rust-lang/futures-rs:futures-executor; crate::local_pool::block_on; Argument[0]; ReturnValue; value |
+| 1 | Summary: futures_executor::local_pool::block_on; Argument[0]; ReturnValue; value |
 edges
 | main.rs:12:28:14:1 | { ... } | main.rs:17:13:17:23 | get_data(...) | provenance |  |
 | main.rs:13:5:13:13 | source(...) | main.rs:12:28:14:1 | { ... } | provenance |  |

rust/ql/test/library-tests/dataflow/sources/TaintSources.expected

@@ -75,7 +75,6 @@
 | test.rs:779:22:779:50 | ...::new | Flow source 'RemoteSource' of type remote (DEFAULT). |
 | test.rs:806:16:806:29 | ...::args | Flow source 'CommandLineArgs' of type commandargs (DEFAULT). |
 | test.rs:806:16:806:29 | ...::args | Flow source 'CommandLineArgs' of type commandargs (DEFAULT). |
-| test_futures_io.rs:19:15:19:32 | ...::connect | Flow source 'RemoteSource' of type remote (DEFAULT). |
 | web_frameworks.rs:11:31:11:31 | a | Flow source 'RemoteSource' of type remote (DEFAULT). |
 | web_frameworks.rs:11:31:11:31 | a | Flow source 'RemoteSource' of type remote (DEFAULT). |
 | web_frameworks.rs:22:14:22:18 | TuplePat | Flow source 'RemoteSource' of type remote (DEFAULT). |

rust/ql/test/library-tests/dataflow/sources/test.rs

@@ -214,7 +214,7 @@ fn test_io_stdin() -> std::io::Result<()> {
     {
         let mut buffer = Vec::<u8>::new();
         let _bytes = std::io::stdin().read_to_end(&mut buffer)?; // $ Alert[rust/summary/taint-sources]
-        sink(&buffer); // $ hasTaintFlow -- @hvitved: works in CI, but not for me locally
+        sink(&buffer); // $ MISSING: hasTaintFlow
     }
 
     {

rust/ql/test/library-tests/dataflow/sources/test_futures_io.rs

@@ -16,21 +16,21 @@ use std::task::{Context, Poll};
 
 async fn test_futures_rustls_futures_io() -> io::Result<()> {
     let url = "www.example.com:443";
-    let tcp = TcpStream::connect(url).await?; // $ Alert[rust/summary/taint-sources]
-    sink(&tcp); // $ hasTaintFlow=url
+    let tcp = TcpStream::connect(url).await?; // $ MISSING: Alert[rust/summary/taint-sources]
+    sink(&tcp); // $ MISSING: hasTaintFlow=url
     let config = rustls::ClientConfig::builder()
         .with_root_certificates(rustls::RootCertStore::empty())
         .with_no_client_auth();
     let connector = TlsConnector::from(Arc::new(config));
     let server_name = rustls::pki_types::ServerName::try_from("www.example.com").unwrap();
     let mut reader = connector.connect(server_name, tcp).await?;
-    sink(&reader); // $ hasTaintFlow=url
+    sink(&reader); // $ MISSING: hasTaintFlow=url
 
     {
         // using the `AsyncRead` trait (low-level)
         let mut buffer = [0u8; 64];
         let mut pinned = Pin::new(&mut reader);
-        sink(&pinned); // $ hasTaintFlow=url
+        sink(&pinned); // $ MISSING: hasTaintFlow=url
         let mut cx = Context::from_waker(futures::task::noop_waker_ref());
         let bytes_read = pinned.poll_read(&mut cx, &mut buffer); // we cannot correctly resolve this call, since it relies on `Deref`
         if let Poll::Ready(Ok(n)) = bytes_read {
@@ -43,7 +43,7 @@ async fn test_futures_rustls_futures_io() -> io::Result<()> {
         // using the `AsyncReadExt::read` extension method (higher-level)
         let mut buffer1 = [0u8; 64];
         let bytes_read1 = futures::io::AsyncReadExt::read(&mut reader, &mut buffer1).await?;
-        sink(&buffer1[..bytes_read1]); // $ hasTaintFlow=url
+        sink(&buffer1[..bytes_read1]); // $ MISSING: hasTaintFlow=url
 
         let mut buffer2 = [0u8; 64];
         let bytes_read2 = reader.read(&mut buffer2).await?; // we cannot resolve the `read` call, which comes from `impl<R: AsyncRead + ?Sized> AsyncReadExt for R {}` in `async_read_ext.rs`
@@ -52,25 +52,25 @@ async fn test_futures_rustls_futures_io() -> io::Result<()> {
     }
 
     let mut reader2 = futures::io::BufReader::new(reader);
-    sink(&reader2); // $ hasTaintFlow=url
+    sink(&reader2); // $ MISSING: hasTaintFlow=url
 
     {
         // using the `AsyncBufRead` trait (low-level)
         let mut pinned = Pin::new(&mut reader2);
-        sink(&pinned); // $ hasTaintFlow=url
+        sink(&pinned); // $ MISSING: hasTaintFlow=url
         let mut cx = Context::from_waker(futures::task::noop_waker_ref());
         let buffer = pinned.poll_fill_buf(&mut cx);
         if let Poll::Ready(Ok(buf)) = buffer {
-            sink(&buffer); // $ hasTaintFlow=url
+            sink(&buffer); // $ MISSING: hasTaintFlow=url
             sink(buf); // $ MISSING: hasTaintFlow=url
         }
 
         // using the `AsyncBufRead` trait (alternative syntax)
         let buffer2 = Pin::new(&mut reader2).poll_fill_buf(&mut cx);
         match (buffer2) {
             Poll::Ready(Ok(buf)) => {
-                sink(&buffer2); // $ hasTaintFlow=url
-                sink(buf); // $ hasTaintFlow=url
+                sink(&buffer2); // $ MISSING: hasTaintFlow=url
+                sink(buf); // $ MISSING: hasTaintFlow=url
             }
             _ => {
                 // ...
@@ -88,7 +88,7 @@ async fn test_futures_rustls_futures_io() -> io::Result<()> {
         // using the `AsyncRead` trait (low-level)
         let mut buffer = [0u8; 64];
         let mut pinned = Pin::new(&mut reader2);
-        sink(&pinned); // $ hasTaintFlow=url
+        sink(&pinned); // $ MISSING: hasTaintFlow=url
         let mut cx = Context::from_waker(futures::task::noop_waker_ref());
         let bytes_read = pinned.poll_read(&mut cx, &mut buffer);
         sink(&buffer); // $ MISSING: hasTaintFlow=url
@@ -101,7 +101,7 @@ async fn test_futures_rustls_futures_io() -> io::Result<()> {
         // using the `AsyncReadExt::read` extension method (higher-level)
         let mut buffer1 = [0u8; 64];
         let bytes_read1 = futures::io::AsyncReadExt::read(&mut reader2, &mut buffer1).await?;
-        sink(&buffer1[..bytes_read1]); // $ hasTaintFlow=url
+        sink(&buffer1[..bytes_read1]); // $ MISSING: hasTaintFlow=url
 
         let mut buffer2 = [0u8; 64];
         let bytes_read2 = reader2.read(&mut buffer2).await?; // we cannot resolve the `read` call, which comes from `impl<R: AsyncRead + ?Sized> AsyncReadExt for R {}` in `async_read_ext.rs`
@@ -111,10 +111,10 @@ async fn test_futures_rustls_futures_io() -> io::Result<()> {
     {
         // using the `AsyncBufRead` trait (low-level)
         let mut pinned = Pin::new(&mut reader2);
-        sink(&pinned); // $ hasTaintFlow=url
+        sink(&pinned); // $ MISSING: hasTaintFlow=url
         let mut cx = Context::from_waker(futures::task::noop_waker_ref());
         let buffer = pinned.poll_fill_buf(&mut cx);
-        sink(&buffer); // $ hasTaintFlow=url
+        sink(&buffer); // $ MISSING: hasTaintFlow=url
         if let Poll::Ready(Ok(buf)) = buffer {
             sink(buf); // $ MISSING: hasTaintFlow=url
         }