Skip to content

Commit a39b2aa

Browse files
Jami CogswellJami Cogswell
authored andcommitted
Java: remove endsWith test case
1 parent ffb2679 commit a39b2aa

File tree

2 files changed

+4
-5
lines changed

2 files changed

+4
-5
lines changed

java/ql/test/library-tests/dataflow/taint/B.java

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -58,19 +58,19 @@ public static void maintest() throws java.io.UnsupportedEncodingException, java.
5858
// non-whitelisted constructors don't pass taint
5959
StringWrapper herring = new StringWrapper(complex);
6060
sink(herring);
61-
// toString does not pass taint yet
61+
// toString does not pass taint yet
6262
String valueOfObject = String.valueOf(args);
6363
sink(valueOfObject);
6464

65-
65+
6666
// tainted equality check with constant
6767
boolean cond = "foo" == s;
6868
sink(cond);
6969
// tainted logic with tainted operand
7070
boolean logic = cond && safe();
7171
sink(logic);
72-
// tainted condition
73-
sink(concat.endsWith("I'm tainted"));
72+
73+
7474
// tainted
7575
logic = safe() || cond;
7676
sink(logic);

java/ql/test/library-tests/dataflow/taint/test.expected

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,6 @@
1818
| B.java:15:21:15:27 | taint(...) | B.java:51:10:51:21 | fluentConcat |
1919
| B.java:15:21:15:27 | taint(...) | B.java:68:10:68:13 | cond |
2020
| B.java:15:21:15:27 | taint(...) | B.java:71:10:71:14 | logic |
21-
| B.java:15:21:15:27 | taint(...) | B.java:73:10:73:39 | endsWith(...) |
2221
| B.java:15:21:15:27 | taint(...) | B.java:76:10:76:14 | logic |
2322
| B.java:15:21:15:27 | taint(...) | B.java:79:10:79:14 | logic |
2423
| B.java:15:21:15:27 | taint(...) | B.java:87:10:87:16 | trimmed |

0 commit comments

Comments
 (0)