change TN to GOOD instead of using hasValueFlow

am0o0 · am0o0 · commit a47c702171fb · 2024-01-15T22:08:35.000+04:00
diff --git a/go/ql/test/experimental/CWE-522-DecompressionBombs/DecompressionBombTest.expected b/go/ql/test/experimental/CWE-522-DecompressionBombs/DecompressionBombTest.expected
@@ -1,3 +1,2 @@
 testFailures
-| test.go:637:31:637:57 | comment | Missing result:hasValueFlow="tarRead" |
 failures
diff --git a/go/ql/test/experimental/CWE-522-DecompressionBombs/test.go b/go/ql/test/experimental/CWE-522-DecompressionBombs/test.go
@@ -634,7 +634,7 @@ func TarDecompressorTN(tarRead *tar.Reader) {
 	var tarOut []byte = make([]byte, 70)
 	i := 1
 	for i > 0 {
-		i, _ = tarRead.Read(tarOut) // $ hasValueFlow="tarRead"
+		i, _ = tarRead.Read(tarOut) // GOOD: the output size is being controlled
 		fmt.Println("do sth with output:", tarOut)
 	}
 }

Original file line number	Diff line number	Diff line change
`@@ -1,3 +1,2 @@`
`1`	`1`	`testFailures`
`2`		`-\| test.go:637:31:637:57 \| comment \| Missing result:hasValueFlow="tarRead" \|`
`3`	`2`	`failures`
Original file line number	Diff line number	Diff line change
`@@ -634,7 +634,7 @@ func TarDecompressorTN(tarRead *tar.Reader) {`
`634`	`634`	`var tarOut []byte = make([]byte, 70)`
`635`	`635`	`i := 1`
`636`	`636`	`for i > 0 {`
`637`		`- i, _ = tarRead.Read(tarOut) // $ hasValueFlow="tarRead"`
	`637`	`+ i, _ = tarRead.Read(tarOut) // GOOD: the output size is being controlled`
`638`	`638`	`fmt.Println("do sth with output:", tarOut)`
`639`	`639`	`}`
`640`	`640`	`}`