Skip to content

Commit a889cc4

Browse files
Jami CogswellJami Cogswell
authored andcommitted
Java/C#: remove isTestLibrary
1 parent 08b5cf1 commit a889cc4

File tree

2 files changed

+2
-8
lines changed

2 files changed

+2
-8
lines changed

csharp/ql/src/Telemetry/ExternalApi.qll

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -24,12 +24,9 @@ class TestLibrary extends RefType {
2424
}
2525
}
2626

27-
/** Holds if the given callable is part of a common testing library or framework. */
28-
private predicate isTestLibrary(DotNet::Callable c) { c.getDeclaringType() instanceof TestLibrary }
29-
3027
/** Holds if the given callable is not worth supporting. */
3128
private predicate isUninteresting(DotNet::Callable c) {
32-
isTestLibrary(c) or
29+
c.getDeclaringType() instanceof TestLibrary or
3330
c.(Constructor).isParameterless()
3431
}
3532

java/ql/src/Telemetry/ExternalApi.qll

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -31,12 +31,9 @@ private string containerAsJar(Container container) {
3131
if container instanceof JarFile then result = container.getBaseName() else result = "rt.jar"
3232
}
3333

34-
/** Holds if the given callable is part of a common testing library or framework. */
35-
private predicate isTestLibrary(Callable c) { c.getDeclaringType() instanceof TestLibrary }
36-
3734
/** Holds if the given callable is not worth supporting. */
3835
private predicate isUninteresting(Callable c) {
39-
isTestLibrary(c) or
36+
c.getDeclaringType() instanceof TestLibrary or
4037
c.(Constructor).isParameterless()
4138
}
4239

0 commit comments

Comments
 (0)