Merge pull request #5992 from hvitved/java/is-unreachable-perf

aschackmull · web-flow · commit acca26f1d61a · 2021-06-03T08:49:51.000+02:00
Java: Improve performance of `isUnreachableInCall()`
diff --git a/java/ql/src/semmle/code/java/dataflow/internal/DataFlowPrivate.qll b/java/ql/src/semmle/code/java/dataflow/internal/DataFlowPrivate.qll
@@ -296,7 +296,9 @@ predicate isUnreachableInCall(Node n, DataFlowCall call) {
     // which is used in a guard
     param.getAUse() = guard and
     // which controls `n` with the opposite value of `arg`
-    guard.controls(n.asExpr().getBasicBlock(), arg.getBooleanValue().booleanNot())
+    guard
+        .controls(n.asExpr().getBasicBlock(),
+          pragma[only_bind_out](arg.getBooleanValue()).booleanNot())
   )
 }
 

Original file line number	Diff line number	Diff line change
`@@ -296,7 +296,9 @@ predicate isUnreachableInCall(Node n, DataFlowCall call) {`
`296`	`296`	`// which is used in a guard`
`297`	`297`	`param.getAUse() = guard and`
`298`	`298`	// which controls `n` with the opposite value of `arg`
`299`		`- guard.controls(n.asExpr().getBasicBlock(), arg.getBooleanValue().booleanNot())`
	`299`	`+ guard`
	`300`	`+ .controls(n.asExpr().getBasicBlock(),`
	`301`	`+ pragma[only_bind_out](arg.getBooleanValue()).booleanNot())`
`300`	`302`	`)`
`301`	`303`	`}`
`302`	`304`