SimpleRangeAnalysis: remove cached

Author: d10c

cpp/ql/lib/semmle/code/cpp/rangeanalysis/SimpleRangeAnalysis.qll

@@ -1563,7 +1563,6 @@ private QlBuiltins::BigInt getGuardedUpperBound(VariableAccess guardedAccess) {
   )
 }
 
-cached
 private module SimpleRangeAnalysisCached {
   /**
    * Gets the lower bound of the expression.
@@ -1577,7 +1576,6 @@ private module SimpleRangeAnalysisCached {
    *
    *    `lowerBound(expr.getFullyConverted())`
    */
-  cached
   QlBuiltins::BigInt lowerBound(Expr expr) {
     // Combine the lower bounds returned by getTruncatedLowerBounds into a
     // single minimum value.
@@ -1596,15 +1594,13 @@ private module SimpleRangeAnalysisCached {
    *
    *    `upperBound(expr.getFullyConverted())`
    */
-  cached
   QlBuiltins::BigInt upperBound(Expr expr) {
     // Combine the upper bounds returned by getTruncatedUpperBounds and
     // getGuardedUpperBound into a single maximum value
     result = min([max(getTruncatedUpperBounds(expr)), getGuardedUpperBound(expr)])
   }
 
   /** Holds if the upper bound of `expr` may have been widened. This means the upper bound is in practice likely to be overly wide. */
-  cached
   predicate upperBoundMayBeWidened(Expr e) {
     isRecursiveExpr(e) and
     // Widening is not a problem if the post-analysis in `getGuardedUpperBound` has overridden the widening.
@@ -1627,7 +1623,6 @@ private module SimpleRangeAnalysisCached {
    *     }
    *   }
    */
-  cached
   predicate exprWithEmptyRange(Expr expr) {
     analyzableExpr(expr) and
     (
@@ -1638,13 +1633,11 @@ private module SimpleRangeAnalysisCached {
   }
 
   /** Holds if the definition might overflow negatively. */
-  cached
   predicate defMightOverflowNegatively(RangeSsaDefinition def, StackVariable v) {
     getDefLowerBoundsImpl(def, v) < varMinVal(v)
   }
 
   /** Holds if the definition might overflow positively. */
-  cached
   predicate defMightOverflowPositively(RangeSsaDefinition def, StackVariable v) {
     getDefUpperBoundsImpl(def, v) > varMaxVal(v)
   }
@@ -1653,7 +1646,6 @@ private module SimpleRangeAnalysisCached {
    * Holds if the definition might overflow (either positively or
    * negatively).
    */
-  cached
   predicate defMightOverflow(RangeSsaDefinition def, StackVariable v) {
     defMightOverflowNegatively(def, v) or
     defMightOverflowPositively(def, v)
@@ -1678,7 +1670,6 @@ private module SimpleRangeAnalysisCached {
    * does not consider the possibility that the expression might overflow
    * due to a conversion.
    */
-  cached
   predicate exprMightOverflowNegatively(Expr expr) {
     getLowerBoundsImpl(expr) < exprMinVal(expr)
     or
@@ -1699,7 +1690,6 @@ private module SimpleRangeAnalysisCached {
    * `(int16)(x+y)` might overflow due to the `(int16)` cast, rather than
    * due to the addition.
    */
-  cached
   predicate convertedExprMightOverflowNegatively(Expr expr) {
     exprMightOverflowNegatively(expr) or
     convertedExprMightOverflowNegatively(expr.getConversion())
@@ -1710,7 +1700,6 @@ private module SimpleRangeAnalysisCached {
    * does not consider the possibility that the expression might overflow
    * due to a conversion.
    */
-  cached
   predicate exprMightOverflowPositively(Expr expr) {
     getUpperBoundsImpl(expr) > exprMaxVal(expr)
     or
@@ -1731,7 +1720,6 @@ private module SimpleRangeAnalysisCached {
    * `(int16)(x+y)` might overflow due to the `(int16)` cast, rather than
    * due to the addition.
    */
-  cached
   predicate convertedExprMightOverflowPositively(Expr expr) {
     exprMightOverflowPositively(expr) or
     convertedExprMightOverflowPositively(expr.getConversion())
@@ -1742,7 +1730,6 @@ private module SimpleRangeAnalysisCached {
    * negatively). The possibility that the expression might overflow
    * due to an implicit or explicit cast is also considered.
    */
-  cached
   predicate convertedExprMightOverflow(Expr expr) {
     convertedExprMightOverflowNegatively(expr) or
     convertedExprMightOverflowPositively(expr)