Skip to content

Commit adddc58

Browse files
committed
address linter
1 parent 494e7d9 commit adddc58

File tree

2 files changed

+12
-17
lines changed

2 files changed

+12
-17
lines changed

ruby/ql/src/experimental/cwe-208/UnsafeHMACComparison.ql renamed to ruby/ql/src/experimental/cwe-208/UnsafeHmacComparison.ql

Lines changed: 12 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -3,31 +3,26 @@ import codeql.ruby.AST
33
import codeql.ruby.DataFlow
44
import codeql.ruby.ApiGraphs
55
import codeql.ruby.dataflow.RemoteFlowSources
6-
import codeql.ruby.ast.Operation
76
import codeql.ruby.TaintTracking
87
import ruby
98

10-
/**
11-
* @kind problem
12-
*/
13-
149
// A call to OpenSSL::HMAC.hexdigest
15-
class OpenSSLHMACHexdigest extends DataFlow::Node {
16-
OpenSSLHMACHexdigest() {
10+
class OpenSslHmacHexdigest extends DataFlow::Node {
11+
OpenSslHmacHexdigest() {
1712
this = API::getTopLevelMember("OpenSSL").getMember("HMAC").getAMethodCall("hexdigest")
1813
}
1914
}
2015

2116
// A call to OpenSSL::HMAC.to_s (which is an alias for OpenSSL::HMAC.hexdigest)
22-
class OpenSSLHMACtos extends DataFlow::Node {
23-
OpenSSLHMACtos() {
17+
class OpenSslHmactos extends DataFlow::Node {
18+
OpenSslHmactos() {
2419
this = API::getTopLevelMember("OpenSSL").getMember("HMAC").getAMethodCall("to_s")
2520
}
2621
}
2722

2823
// A call to OpenSSL::HMAC.digest
29-
class OpenSSLHMACdigest extends DataFlow::Node {
30-
OpenSSLHMACdigest() {
24+
class OpenSslHmacdigest extends DataFlow::Node {
25+
OpenSslHmacdigest() {
3126
this = API::getTopLevelMember("OpenSSL").getMember("HMAC").getAMethodCall("digest")
3227
}
3328
}
@@ -40,8 +35,8 @@ class OpenSSLnewHMAC extends DataFlow::Node {
4035
}
4136

4237
// A call to OpenSSL::HMAC.base64digest
43-
class OpenSSLHmacbase64digest extends DataFlow::Node {
44-
OpenSSLHmacbase64digest() {
38+
class OpenSslHmacbase64digest extends DataFlow::Node {
39+
OpenSslHmacbase64digest() {
4540
this = API::getTopLevelMember("OpenSSL").getMember("HMAC").getAMethodCall("base64digest")
4641
}
4742
}
@@ -50,11 +45,11 @@ class Configuration extends DataFlow::Configuration {
5045
Configuration() { this = "UnsafeHMACComparison" }
5146

5247
override predicate isSource(DataFlow::Node source) {
53-
source instanceof OpenSSLHMACHexdigest or
48+
source instanceof OpenSslHmacHexdigest or
5449
source instanceof OpenSSLnewHMAC or
55-
source instanceof OpenSSLHmacbase64digest or
56-
source instanceof OpenSSLHMACdigest or
57-
source instanceof OpenSSLHMACtos
50+
source instanceof OpenSslHmacbase64digest or
51+
source instanceof OpenSslHmacdigest or
52+
source instanceof OpenSslHmactos
5853
}
5954

6055
// Holds if a given sink is an Equality Operation (== or !=)

0 commit comments

Comments
 (0)