File tree Expand file tree Collapse file tree 1 file changed +6
-4
lines changed
javascript/ql/lib/semmle/javascript/frameworks Expand file tree Collapse file tree 1 file changed +6
-4
lines changed Original file line number Diff line number Diff line change @@ -23,7 +23,7 @@ module CookieWrites {
23
23
abstract predicate isHttpOnly ( ) ;
24
24
25
25
/**
26
- * Holds if the cookie is likely an authentication cookie or otherwise sensitive.
26
+ * Holds if the cookie likely is an authentication cookie or otherwise sensitive.
27
27
*/
28
28
abstract predicate isSensitive ( ) ;
29
29
@@ -57,8 +57,10 @@ module CookieWrites {
57
57
58
58
/**
59
59
* Holds if `node` looks like it can contain a sensitive cookie.
60
- * Either from `node` being a sensitive expression, or from `node` containing
61
- * a string value that looks like a sensitive cookie name.
60
+ *
61
+ * Heuristics:
62
+ * - `node` contains a string value that looks like a sensitive cookie name
63
+ * - `node` is a sensitive expression
62
64
*/
63
65
private predicate canHaveSensitiveCookie ( DataFlow:: Node node ) {
64
66
exists ( string s |
@@ -72,7 +74,7 @@ private predicate canHaveSensitiveCookie(DataFlow::Node node) {
72
74
}
73
75
74
76
/**
75
- * Gets cookie name from a `Set-Cookie` header value.
77
+ * Gets the cookie name of a `Set-Cookie` header value.
76
78
* The header value always starts with `<cookie-name>=<cookie-value>` optionally followed by attributes:
77
79
* `<cookie-name>=<cookie-value>; Domain=<domain-value>; Secure; HttpOnly`
78
80
*/
You can’t perform that action at this time.
0 commit comments