C++: Remove unnecessary additional taint step.

geoffw0 · geoffw0 · commit b142a79a35f2 · 2021-12-15T14:35:54.000Z
diff --git a/cpp/ql/src/Security/CWE/CWE-311/CleartextTransmission.ql b/cpp/ql/src/Security/CWE/CWE-311/CleartextTransmission.ql
@@ -177,10 +177,6 @@ class FromSensitiveConfiguration extends TaintTracking::Configuration {
   }
 
   override predicate isAdditionalTaintStep(DataFlow::Node node1, DataFlow::Node node2) {
-    // flow from pre-update to post-update of the source
-    isSource(node1) and
-    node2.(DataFlow::PostUpdateNode).getPreUpdateNode() = node1
-    or
     // flow through encryption functions to the return value (in case we can reach other sinks)
     node2.asExpr().(Encrypted).(FunctionCall).getAnArgument() = node1.asExpr()
   }

Original file line number	Diff line number	Diff line change
`@@ -177,10 +177,6 @@ class FromSensitiveConfiguration extends TaintTracking::Configuration {`
`177`	`177`	`}`
`178`	`178`
`179`	`179`	`override predicate isAdditionalTaintStep(DataFlow::Node node1, DataFlow::Node node2) {`
`180`		`- // flow from pre-update to post-update of the source`
`181`		`- isSource(node1) and`
`182`		`- node2.(DataFlow::PostUpdateNode).getPreUpdateNode() = node1`
`183`		`- or`
`184`	`180`	`// flow through encryption functions to the return value (in case we can reach other sinks)`
`185`	`181`	`node2.asExpr().(Encrypted).(FunctionCall).getAnArgument() = node1.asExpr()`
`186`	`182`	`}`